Replace some instances of FxHashMap/FxHashSet with stable alternatives (mostly in rustc_hir and rustc_ast_lowering)

[michaelwoerister]

Part of rust-lang/compiler-team#533. We should be getting close to being able to remove the HashStable impl of HashMap.

[rustbot]

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

[petrochenkov]

There are some maps here that may be performance critical.
@bors try @rust-timer queue

[petrochenkov]

r=me if the perf run doesn't show regressions.

[bors]

⌛ Trying commit 115885b with merge 91fa6d2...

[bors]

☀️ Try build successful - checks-actions
Build commit: 91fa6d2 (91fa6d2b8ab99cfd2b8a0fa8bad8411b21bbcd62)

[rust-timer]

Finished benchmarking commit (91fa6d2): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.2%	[4.2%, 4.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[-0.8%, 4.2%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.9%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.9%, 0.7%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.523s -> 671.262s (-0.34%)
Artifact size: 312.51 MiB -> 312.45 MiB (-0.02%)

[michaelwoerister]

r=me if the perf run doesn't show regressions.

Perf run looks good. Thanks for the review, @petrochenkov!

@bors r=petrochenkov

[bors]

📌 Commit 115885b has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 115885b with merge 32f5db9...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 32f5db9 to master...

[rust-timer]

Finished benchmarking commit (32f5db9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-0.9%, 2.4%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.2%	[8.1%, 10.5%]	3
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	6.8%	[-0.5%, 10.5%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.446s -> 672.427s (0.15%)
Artifact size: 312.47 MiB -> 312.51 MiB (0.01%)

[lqd]

The cycles regressions have got to be noise?!