Move term, terminfo out of extra. #11945
Conversation
|
It seems like these could be in one crate, e.g. |
| html_favicon_url = "http://www.rust-lang.org/favicon.ico", | ||
| html_root_url = "http://static.rust-lang.org/doc/master")]; | ||
|
|
||
| #[feature(globs)]; |
There was a problem hiding this comment.
Did this end up being too painful to remove?
There was a problem hiding this comment.
The only toplevel item in terminfo is the TermInfo struct. I'm pretty sure this glob is unnecessary.
|
I agree with @huonw , I would expect these modules to form |
|
I am so excited to see all this action with libextra! |
|
Happy to see libextra being taken apart. 🎉 |
|
I agree with @huonw and @alexcrichton. I also think "terminfo" is one word so |
|
|
||
| #[deny(non_camel_case_types)]; | ||
| #[allow(missing_doc)]; | ||
|
|
||
| use std::os; | ||
| use terminfo::*; |
There was a problem hiding this comment.
It looks like this may be the only glob in this crate, could you remove this glob and feature(globs) as well?
|
Feel free to comment on the PR whenever you update it, sadly no one gets notifications about force-pushes. Also, could you squash all the commits into one? Thanks for doing this! |
|
Sure. Removed globs. |
|
Maybe this should be added to |
|
Added to docs. |
|
Fixed imports in tests; they pass now. |
|
This needs a rebase. |
|
Rebased. |
|
Is there no place now to view the docs of these external crates? |
|
Oops never mind. They can be found on this page. |
…tly, r=harpsword fix cargo check diagnostics are mapped incorrectly with non-BMP codepoints fix rust-lang#11945
…xendoo Try to improve wording and fix dead link in description of arc_with_non_send_sync lint. changelog: [`arc_with_non_send_sync`]: Improve wording and fix dead link.
cc #8784