Skip to content

Two small bitset optimisations #119499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Two small bitset optimisations #119499

merged 2 commits into from
Jan 6, 2024

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jan 1, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2024

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 1, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 1, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 1, 2024
@bors
Copy link
Collaborator

bors commented Jan 1, 2024

⌛ Trying commit 831f25f with merge f67a248...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2024
@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 1, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jan 1, 2024

⌛ Trying commit 7d6b11d with merge ac94b01...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2024
@bors
Copy link
Collaborator

bors commented Jan 1, 2024

☀️ Try build successful - checks-actions
Build commit: ac94b01 (ac94b0166674fe0d08b9b26c2f918c4ec6d15a8e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ac94b01): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.9% [2.9%, 2.9%] 1
Regressions ❌
(secondary)
4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.9% [2.9%, 2.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.95s -> 669.21s (0.34%)
Artifact size: 311.74 MiB -> 311.75 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 1, 2024
@nnethercote
Copy link
Contributor

@bors delegate=cjgillot

Looks good to me, though it would be nice if the changes to clone_from could be reverted, reducing this to just two commits.

@bors
Copy link
Collaborator

bors commented Jan 2, 2024

✌️ @cjgillot, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 2, 2024

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented Jan 2, 2024

📌 Commit 0adfe20 has been approved by nnethercote

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 2, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 2, 2024
@bors
Copy link
Collaborator

bors commented Jan 6, 2024

⌛ Testing commit 0adfe20 with merge efb3f11...

@bors
Copy link
Collaborator

bors commented Jan 6, 2024

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing efb3f11 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2024
@bors bors merged commit efb3f11 into rust-lang:master Jan 6, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 6, 2024
@cjgillot cjgillot deleted the dtm-opt branch January 6, 2024 14:34
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (efb3f11): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.0%, 3.5%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.487s -> 665.507s (-0.15%)
Artifact size: 308.53 MiB -> 308.52 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants