Make min_exhaustive_patterns match exhaustive_patterns better#120775
Merged
bors merged 2 commits intorust-lang:masterfrom Feb 8, 2024
Merged
Make min_exhaustive_patterns match exhaustive_patterns better#120775bors merged 2 commits intorust-lang:masterfrom
min_exhaustive_patterns match exhaustive_patterns better#120775bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
This was referenced Feb 8, 2024
Nadrieril
changed the title
min_exhaustive_patterns implementation with exhaustive_patternsmin_exhaustive_patterns match exhaustive_patterns better
compiler-errors
approved these changes
Feb 8, 2024
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
Ty! @bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#120590 (Remove unused args from functions) - rust-lang#120750 (No need to take `ImplTraitContext` by ref) - rust-lang#120769 (make future diffs minimal) - rust-lang#120772 (Remove myself from review rotation.) - rust-lang#120775 (Make `min_exhaustive_patterns` match `exhaustive_patterns` better) - rust-lang#120778 (Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`) - rust-lang#120782 (Fix mir pass ICE in the presence of other errors) - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint) - rust-lang#120801 (Avoid ICE in drop recursion check in case of invalid drop impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
Rollup merge of rust-lang#120775 - Nadrieril:more-min_exh_pats, r=compiler-errors Make `min_exhaustive_patterns` match `exhaustive_patterns` better Split off from rust-lang#120742. There remained two edge cases where `min_exhaustive_patterns` wasn't behaving like `exhaustive_patterns`. This fixes them, and tests the feature in a bunch more cases. I essentially went through all uses of `exhaustive_patterns` to see which ones would be interesting to compare between the two features. r? `@compiler-errors`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #120742.
There remained two edge cases where
min_exhaustive_patternswasn't behaving likeexhaustive_patterns. This fixes them, and tests the feature in a bunch more cases. I essentially went through all uses ofexhaustive_patternsto see which ones would be interesting to compare between the two features.r? @compiler-errors