Skip to content

replace <commit> placeholder with the actual commit in vendoring error #120814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

replace <commit> placeholder with the actual commit in vendoring error #120814

wants to merge 2 commits into from

Conversation

carlosguealv
Copy link

fixes #120499

@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 8, 2024
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort!

I believe there might have been a misunderstanding regarding the task. I have revised the issue description and included clear instructions on how to proceed to achieve the desired outcome.

@onur-ozkan
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2024
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Feb 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@carlosguealv carlosguealv closed this by deleting the head repository Feb 11, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=carlosguealv
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_ebacfa0f-6913-4173-8313-f62ad19ba7df
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=fc9a2d2cb849489b10e389bcfc5456b3fc64599f
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_ebacfa0f-6913-4173-8313-f62ad19ba7df
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_ebacfa0f-6913-4173-8313-f62ad19ba7df
GITHUB_TRIGGERING_ACTOR=carlosguealv
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/120814/merge
GITHUB_WORKFLOW_SHA=fc9a2d2cb849489b10e389bcfc5456b3fc64599f
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---
#12 writing image sha256:20ce35572adc07c7949db8a30e5b3b8ff4de8ae115125b909a66d781702ddc24 done
#12 naming to docker.io/library/rust-ci done
#12 DONE 10.0s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-16]
##[group]Clock drift check
  local time: Sun Feb 11 20:25:45 UTC 2024
  network time: Sun, 11 Feb 2024 20:25:45 GMT
  network time: Sun, 11 Feb 2024 20:25:45 GMT
##[endgroup]
sccache: Starting the server...
Traceback (most recent call last):
  File "/checkout/src/bootstrap/configure.py", line 12, in <module>
    import bootstrap # noqa: E402
  File "/checkout/src/bootstrap/bootstrap.py", line 14, in <module>
    import requests
    import requests
ModuleNotFoundError: No module named 'requests'
  network time: Sun, 11 Feb 2024 20:25:45 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace <commit> placeholder with the actual commit in vendoring error
5 participants