Skip to content

Revert "Auto merge of #122140 - oli-obk:track_errors13, r=davidtwco" #122347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 11, 2024

This reverts commit 65cd843, reversing changes made to d255c6a.

reverts #122140

It was a large regression in wall time due to trashing CPU caches

…vidtwco"

This reverts commit 65cd843, reversing
changes made to d255c6a.
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 11, 2024

@bors rollup=never

@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2024
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 12, 2024

📌 Commit 96d24f2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@bors
Copy link
Collaborator

bors commented Mar 14, 2024

⌛ Testing commit 96d24f2 with merge 5ac0b2d...

@bors
Copy link
Collaborator

bors commented Mar 14, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5ac0b2d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2024
@bors bors merged commit 5ac0b2d into rust-lang:master Mar 14, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 14, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5ac0b2d): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-0.9%, 0.2%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [0.8%, 3.2%] 4
Regressions ❌
(secondary)
4.7% [4.7%, 4.7%] 1
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% [-2.9%, 3.2%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [1.7%, 1.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.1% [-12.3%, -1.3%] 60
Improvements ✅
(secondary)
-10.3% [-19.0%, -2.1%] 19
All ❌✅ (primary) -4.0% [-12.3%, 1.7%] 61

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.02s -> 667.978s (-1.34%)
Artifact size: 310.67 MiB -> 310.75 MiB (0.03%)

@oli-obk oli-obk deleted the track_errors13 branch March 26, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants