Skip to content

Print the crates not available as static #122359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 12, 2024

This prints out the crates not available to be statically linked when static linking is preferred and we run into an error with duplicated crates.

@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2024
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice improvement to the error message! Is there a way we can add a test that covers this?

@Zoxc Zoxc force-pushed the missing-static-notes branch from a5616aa to 38518c4 Compare March 16, 2024 16:12
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 16, 2024

I tried to write a test, but it looked like it duplicated std instead of giving an error message.

@wesleywiser
Copy link
Member

Ok, thanks for looking into it! I'm fine without a test then.

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 20, 2024

📌 Commit 38518c4 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2024
@bors
Copy link
Collaborator

bors commented Mar 20, 2024

⌛ Testing commit 38518c4 with merge 94b72d6...

@bors
Copy link
Collaborator

bors commented Mar 20, 2024

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 94b72d6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2024
@bors bors merged commit 94b72d6 into rust-lang:master Mar 20, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 20, 2024
@Zoxc Zoxc deleted the missing-static-notes branch March 20, 2024 18:45
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (94b72d6): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.1% [-6.1%, -6.1%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.372s -> 669.176s (-0.03%)
Artifact size: 312.78 MiB -> 312.73 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants