-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Print the crates not available as static #122359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use r? to explicitly pick a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a nice improvement to the error message! Is there a way we can add a test that covers this?
a5616aa
to
38518c4
Compare
I tried to write a test, but it looked like it duplicated |
Ok, thanks for looking into it! I'm fine without a test then. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (94b72d6): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.372s -> 669.176s (-0.03%) |
This prints out the crates not available to be statically linked when static linking is preferred and we run into an error with duplicated crates.