Skip to content

Miri subtree update #122538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Mar 15, 2024
Merged

Miri subtree update #122538

merged 29 commits into from
Mar 15, 2024

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 29 commits March 9, 2024 19:10
set panic=abort so that we do not need this eh_personality thing
simplify no-std tests

set panic=abort so that we do not need this eh_personality thing
Since rust-lang#121956 we don't need it any more,
and we are generally short on Windows staff so reducing the amount of code we
have to test and maintain sounds like a good idea.

The InitOnce stuff is still used by `thread_local_key::StaticKey`.
windows: remove support for slim rwlock

Since rust-lang#121956 we don't need it any more, and we are generally short on Windows staff so reducing the amount of code we have to test and maintain sounds like a good idea.

The InitOnce stuff is still used by `thread_local_key::StaticKey` on 64bit windows-gnu.
…hlin

Improve sysroots notification

* Removes the T-miri ping (because these failures can't be acted on quickly, ergo they cannot be urgent)
* Puts the message in a separate Zulip topic
* Lists which targets failed to build in the Zulip message
make cron job topic names more consistent
explain time-with-isolation test better

Fixes rust-lang/miri#3377

`@saethlin` do you think this is better?
…hlin

Fix sysroot notification list of broken targets

We use this same shell quoting trick on the line above to expand shell variables into the job URL. So this should work a line down as well... right?
@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2024

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2024
@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Mar 15, 2024

📌 Commit 6d9549f has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@bors
Copy link
Collaborator

bors commented Mar 15, 2024

⌛ Testing commit 6d9549f with merge accc516...

@bors
Copy link
Collaborator

bors commented Mar 15, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing accc516 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 15, 2024
@bors bors merged commit accc516 into rust-lang:master Mar 15, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 15, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (accc516): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.4% [1.1%, 3.6%] 3
Regressions ❌
(secondary)
1.9% [1.9%, 1.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 2.4% [1.1%, 3.6%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.842s -> 671.321s (0.22%)
Artifact size: 311.44 MiB -> 311.51 MiB (0.02%)

@RalfJung RalfJung deleted the miri branch March 15, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants