-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove len argument from RawVec::reserve_for_push #122976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #122396) made this pull request unmergeable. Please resolve the merge conflicts. |
reserve_one sounds like an specialized version of reserve(1). Unlike reserve(1), it always grows. I think a name like grow_one |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
… equal to capacity. Also make Vec::insert use reserve_for_push.
eee4067
to
78dc89b
Compare
@rustbot review |
That looks fine to me! @bors r+ |
…=cuviper Remove len argument from RawVec::reserve_for_push Removes `RawVec::reserve_for_push`'s `len` argument since it's always the same as capacity. Also makes `Vec::insert` use `RawVec::reserve_for_push`.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
That's a legitimate failure, but it should be a straightforward update of the expected strings. |
@rustbot review |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (877d36b): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 668.236s -> 671.487s (0.49%) |
Removes
RawVec::reserve_for_push
'slen
argument since it's always the same as capacity.Also makes
Vec::insert
useRawVec::reserve_for_push
.