-
Notifications
You must be signed in to change notification settings - Fork 13.3k
copy any file from stage0/lib to stage0-sysroot/lib #123186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the LLVM 18 upgrade, the name of the LLVM library has been changed to something like `libLLVM.so.18.1-rust-1.78.0-beta`, which `is_dylib` function cannot determine as it only looks whether files are ending with ".so" or not. This change resolves this problem by no longer doing that ".so" check, as we need all files from the stage0/lib as they are all dependency of rustc anyway. Signed-off-by: onur-ozkan <[email protected]>
rustbot has assigned @albertlarsan68. Use |
Confirmed that the LLVM file is copied into @bors r+ rollup |
I thought I fixed is_dylib when I fixed the nix patching? |
That might be an orthogonal issue, but I would personally prefer to copy everything anyway, we just want to duplicate the |
Library name is rust/src/bootstrap/src/utils/helpers.rs Lines 56 to 59 in 760e567
|
We also have a linker script file that ends with |
ah no, I created a competing implementation https://github.com/rust-lang/rust/pull/122911/files#diff-11a177c4925352bc8852241c59fd49c369df531495f11f81914eb6972783bb8aR747 |
copy any file from stage0/lib to stage0-sysroot/lib With the LLVM 18 upgrade, the name of the LLVM library has been changed to something like `libLLVM.so.18.1-rust-1.78.0-beta`, which `is_dylib` function cannot determine as it only looks whether files are ending with ".so" or not. This change resolves this problem by no longer doing that ".so" check, as we need all files from the stage0/lib as they are all dependency of rustc anyway. Fixes rust-lang#122913
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#123106 (CFI: Abstract Closures and Coroutines) - rust-lang#123176 (Normalize the result of `Fields::ty_with_args`) - rust-lang#123186 (copy any file from stage0/lib to stage0-sysroot/lib) - rust-lang#123187 (Forward port 1.77.1 release notes) - rust-lang#123188 (compiler: fix few unused_peekable and needless_pass_by_ref_mut clippy lints) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#123176 (Normalize the result of `Fields::ty_with_args`) - rust-lang#123186 (copy any file from stage0/lib to stage0-sysroot/lib) - rust-lang#123187 (Forward port 1.77.1 release notes) - rust-lang#123188 (compiler: fix few unused_peekable and needless_pass_by_ref_mut clippy lints) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123186 - onur-ozkan:llvm-library-bug, r=Kobzol copy any file from stage0/lib to stage0-sysroot/lib With the LLVM 18 upgrade, the name of the LLVM library has been changed to something like `libLLVM.so.18.1-rust-1.78.0-beta`, which `is_dylib` function cannot determine as it only looks whether files are ending with ".so" or not. This change resolves this problem by no longer doing that ".so" check, as we need all files from the stage0/lib as they are all dependency of rustc anyway. Fixes rust-lang#122913
With the LLVM 18 upgrade, the name of the LLVM library has been changed to something like
libLLVM.so.18.1-rust-1.78.0-beta
, whichis_dylib
function cannot determine as it only looks whether files are ending with ".so" or not.This change resolves this problem by no longer doing that ".so" check, as we need all files from the stage0/lib as they are all dependency of rustc anyway.
Fixes #122913