Spellcheck library docs. #12345
Merged
Spellcheck library docs. #12345
+14
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow I thought you were joking. I should have known better. |
| @@ -1111,7 +1111,7 @@ impl MetricMap { | |||
|
|
|||
| // Benchmarking | |||
|
|
|||
| /// A function that is opaque to the optimiser, to allow benchmarks to | |||
| /// A function that is opaque to the optimizer, to allow benchmarks to | |||
There was a problem hiding this comment.
It was right the first time :P
There was a problem hiding this comment.
I wish the codebase was in UK english too, but alas!
There was a problem hiding this comment.
In deference to Rust's origins, I propose we standardize on whatever spellings are used in British Columbia.
There was a problem hiding this comment.
Maybe the standard spelling used by fungi would be appropriate too?
There was a problem hiding this comment.
I second @bstrie 's vote since I am also a British Columbian.
|
Congratulations on commit #12345! |
| @@ -144,7 +144,7 @@ impl Select { | |||
| } | |||
| } | |||
|
|
|||
| /// Waits for an event on this port set. The returned valus is *not* and | |||
| /// Waits for an event on this port set. The returned value is *not* and | |||
There was a problem hiding this comment.
Thanks for noticing; fixed.
bors
added a commit
that referenced
this pull request
Feb 18, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…kril feat: escape format specifier(close: rust-lang#12258) solve rust-lang/rust-analyzer#12258
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2023
…i-obk Rework `no_coverage` to `coverage(off)` As discussed at the tail of rust-lang#84605 this replaces the `no_coverage` attribute with a `coverage` attribute that takes sub-parameters (currently `off` and `on`) to control the coverage instrumentation. Allows future-proofing for things like `coverage(off, reason="Tested live", issue="rust-lang#12345")` or similar.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
…ces, r=xFrednet Pause PR assignments for xFrednet :) My life is currently a bit chaotic, and it feels like I can't give reviews the attention they need. I'll finish the PRs I'm assigned to, write the changelogs, and am available when I get pinged etc. This is only intended as a temporary pause, as I still genuinely enjoy working with everyone in this repo and seeing Clippy grow day by day. --- changelog: none r? `@ghost`
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 19, 2025
…kport-poll, r=aDotInTheVoid
Add option for stable backport poll
When creating polls on Zulip about stable backport ("Do we approve the backport of `rust-lang#12345`"?), stable backports should have the option of "approving, but only is a dot release is planned" (this is a hint to t-release about how the team think important - or not - is backporting some patch).
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stable-nominated.3A.20.23139328/near/510037866)[#t-rustdoc > stable-nominated: rust-lang#139328 @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stable-nominated.3A.20.23139328/near/510037866)
r? `@aDotInTheVoid` (feel free to adjust the wording!)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2025
Rollup merge of rust-lang#140039 - apiraino:add-option-for-stable-backport-poll, r=aDotInTheVoid Add option for stable backport poll When creating polls on Zulip about stable backport ("Do we approve the backport of `rust-lang#12345`"?), stable backports should have the option of "approving, but only is a dot release is planned" (this is a hint to t-release about how the team think important - or not - is backporting some patch). Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stable-nominated.3A.20.23139328/near/510037866)[#t-rustdoc > stable-nominated: rust-lang#139328 @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stable-nominated.3A.20.23139328/near/510037866) r? `@aDotInTheVoid` (feel free to adjust the wording!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.