Skip to content

crashes: add a couple more ICE tests #124236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

crashes: add a couple more ICE tests #124236

merged 1 commit into from
Apr 22, 2024
+62 −0

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2024
@jieyouxu
Copy link
Member

Feel free to r=me after CI is green.
@bors rollup=iffy

@matthiaskrgr
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Apr 21, 2024

📌 Commit 6774801 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2024
@bors
Copy link
Collaborator

bors commented Apr 21, 2024

⌛ Testing commit 6774801 with merge b6ea68c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2024
@bors
Auto merge of rust-lang#124236 - matthiaskrgr:n-ice, r=jieyouxu
b6ea68c 
crashes: add a couple more ICE tests
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] cargo_test_macro test:false 0.795
   Compiling gix-macros v0.1.4
[RUSTC-TIMING] rusqlite test:false 2.209
   Compiling openssl-macros v0.1.1
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
    Checking color-print v0.3.5
[RUSTC-TIMING] color_print test:false 0.090
[RUSTC-TIMING] fiat_crypto test:false 10.427
    Checking orion v0.17.6

@bors
Copy link
Collaborator

bors commented Apr 22, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2024
@matthiaskrgr
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#124236 - matthiaskrgr:n-ice, r=jieyouxu
ea6e206 
crashes: add a couple more ICE tests
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 22, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
@bors
Auto merge of rust-lang#124248 - matthiaskrgr:rollup-tt6fq7h, r=matth…
12e8cda 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124236 (crashes: add a couple more ICE tests)
 - rust-lang#124240 (add a couple tests for fixed ICEs.)
 - rust-lang#124246 (Add comma at one place in `abs()` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Apr 22, 2024

⌛ Testing commit 6774801 with merge b3e1170...

@bors
Copy link
Collaborator

bors commented Apr 22, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing b3e1170 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2024
@bors bors merged commit b3e1170 into rust-lang:master Apr 22, 2024
13 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 22, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b3e1170): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [3.3%, 3.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.523s -> 671.828s (0.05%)
Artifact size: 315.42 MiB -> 315.40 MiB (-0.01%)

@matthiaskrgr matthiaskrgr deleted the n-ice branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @rustbot @jieyouxu @bors @rust-log-analyzer @rust-timer @Mark-Simulacrum