Skip to content

Remove some non-essential trait re-exports from the prelude. #12485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libcollections/hashmap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
//! ```

use std::cmp::max;
use std::default::Default;
use std::fmt;
use std::hash::{Hash, Hasher, sip};
use std::iter::{FilterMap, Chain, Repeat, Zip};
Expand Down
1 change: 1 addition & 0 deletions src/libextra/url.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use std::cmp::Eq;
use std::fmt;
use std::hash::{Hash, sip};
use std::io::BufReader;
use std::from_str::FromStr;
use std::uint;

use collections::HashMap;
Expand Down
6 changes: 4 additions & 2 deletions src/libnum/bigint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use Integer;

use std::cmp;
use std::fmt;
use std::from_str::FromStr;
use std::num::{Bitwise, ToPrimitive, FromPrimitive};
use std::num::{Zero, One, ToStrRadix, FromStrRadix};
use std::rand::Rng;
Expand Down Expand Up @@ -1397,8 +1398,9 @@ mod biguint_tests {
use super::{Plus, BigInt, RandBigInt, ToBigInt};

use std::cmp::{Less, Equal, Greater};
use std::from_str::FromStr;
use std::i64;
use std::num::{Zero, One, FromStrRadix};
use std::num::{Zero, One, FromStrRadix, ToStrRadix};
use std::num::{ToPrimitive, FromPrimitive};
use std::rand::{task_rng};
use std::str;
Expand Down Expand Up @@ -2056,7 +2058,7 @@ mod bigint_tests {

use std::cmp::{Less, Equal, Greater};
use std::i64;
use std::num::{Zero, One, FromStrRadix};
use std::num::{Zero, One, FromStrRadix, ToStrRadix};
use std::num::{ToPrimitive, FromPrimitive};
use std::rand::{task_rng};
use std::u64;
Expand Down
2 changes: 1 addition & 1 deletion src/libnum/rational.rs
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ impl<T: FromStrRadix + Clone + Integer + Ord>
mod test {

use super::{Ratio, Rational, BigRational};
use std::num::{Zero,One,FromStrRadix,FromPrimitive};
use std::num::{Zero, One, FromStrRadix, FromPrimitive, ToStrRadix};
use std::from_str::FromStr;

pub static _0 : Rational = Ratio { numer: 0, denom: 1};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/bool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ impl Default for bool {
mod tests {
use prelude::*;
use super::all_values;
use from_str::FromStr;

#[test]
fn test_bool() {
Expand Down
1 change: 1 addition & 0 deletions src/libstd/io/net/ip.rs
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ impl FromStr for SocketAddr {
mod test {
use prelude::*;
use super::*;
use from_str::FromStr;

#[test]
fn test_from_str_ipv4() {
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/f32.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ use prelude::*;

use cmath;
use default::Default;
use from_str::FromStr;
use libc::{c_float, c_int};
use num::{FPCategory, FPNaN, FPInfinite , FPZero, FPSubnormal, FPNormal};
use num::{Zero, One, Bounded, strconv};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/f64.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use prelude::*;

use cmath;
use default::Default;
use from_str::FromStr;
use libc::{c_double, c_int};
use num::{FPCategory, FPNaN, FPInfinite , FPZero, FPSubnormal, FPNormal};
use num::{Zero, One, Bounded, strconv};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/i16.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded, CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
use num::{ToStrRadix, FromStrRadix};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/i32.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded, CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
use num::{ToStrRadix, FromStrRadix};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/i64.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
#[cfg(target_word_size = "64")]
use num::CheckedMul;
use num::{Bitwise, Bounded, CheckedAdd, CheckedSub};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/i8.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded, CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
use num::{ToStrRadix, FromStrRadix};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/int.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded, CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
use num::{ToStrRadix, FromStrRadix};
Expand Down
3 changes: 2 additions & 1 deletion src/libstd/num/int_macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,9 @@ mod tests {
use int;
use i32;
use num;
use num::CheckedDiv;
use num::Bitwise;
use num::CheckedDiv;
use num::ToStrRadix;

#[test]
fn test_overflows() {
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/u16.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded};
use num::{CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/u32.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded};
use num::{CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/u64.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded};
#[cfg(target_word_size = "64")]
use num::CheckedMul;
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/u8.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded};
use num::{CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/uint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use prelude::*;

use default::Default;
use from_str::FromStr;
use num::{Bitwise, Bounded};
use num::{CheckedAdd, CheckedSub, CheckedMul};
use num::{CheckedDiv, Zero, One, strconv};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/num/uint_macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ mod tests {
use num;
use num::CheckedDiv;
use num::Bitwise;
use num::ToStrRadix;
use u16;

#[test]
Expand Down
4 changes: 1 addition & 3 deletions src/libstd/prelude.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,12 @@ pub use char::Char;
pub use clone::{Clone, DeepClone};
pub use cmp::{Eq, Ord, TotalEq, TotalOrd, Ordering, Less, Equal, Greater, Equiv};
pub use container::{Container, Mutable, Map, MutableMap, Set, MutableSet};
pub use default::Default;
pub use from_str::FromStr;
pub use iter::{FromIterator, Extendable};
pub use iter::{Iterator, DoubleEndedIterator, RandomAccessIterator, CloneableIterator};
pub use iter::{OrdIterator, MutableDoubleEndedIterator, ExactSize};
pub use num::{Num, NumCast, CheckedAdd, CheckedSub, CheckedMul};
pub use num::{Signed, Unsigned, Round};
pub use num::{Primitive, Int, Float, ToStrRadix, ToPrimitive, FromPrimitive};
pub use num::{Primitive, Int, Float, ToPrimitive, FromPrimitive};
pub use path::{GenericPath, Path, PosixPath, WindowsPath};
pub use ptr::RawPtr;
pub use io::{Buffer, Writer, Reader, Seek};
Expand Down
1 change: 1 addition & 0 deletions src/libstd/rand/reseeding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ impl Default for ReseedWithDefault {
mod test {
use prelude::*;
use super::*;
use default::Default;
use rand::{SeedableRng, Rng};

struct Counter {
Expand Down
1 change: 1 addition & 0 deletions src/libstd/str.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3072,6 +3072,7 @@ impl Default for ~str {
#[cfg(test)]
mod tests {
use iter::AdditiveIterator;
use default::Default;
use prelude::*;
use str::*;

Expand Down
3 changes: 3 additions & 0 deletions src/libsyntax/crateid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ use std::fmt;
/// `1.0`. If no crate name is given after the hash, the name is inferred to
/// be the last component of the path. If no version is given, it is inferred
/// to be `0.0`.

use std::from_str::FromStr;

#[deriving(Clone, Eq)]
pub struct CrateId {
/// A path which represents the codes origin. By convention this is the
Expand Down
1 change: 1 addition & 0 deletions src/libsyntax/opt_vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/

use std::vec;
use std::default::Default;

#[deriving(Clone, Encodable, Decodable, Hash)]
pub enum OptVec<T> {
Expand Down
1 change: 1 addition & 0 deletions src/libtest/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ use term::color::{Color, RED, YELLOW, GREEN, CYAN};
use std::cmp;
use std::f64;
use std::fmt;
use std::from_str::FromStr;
use std::io::stdio::StdWriter;
use std::io::{File, PortReader, ChanWriter};
use std::io;
Expand Down
2 changes: 2 additions & 0 deletions src/libuuid/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ extern crate serialize;

use std::cast::{transmute,transmute_copy};
use std::char::Char;
use std::default::Default;
use std::fmt;
use std::from_str::FromStr;
use std::hash::{Hash, sip};
use std::num::FromStrRadix;
use std::rand::Rng;
Expand Down
2 changes: 2 additions & 0 deletions src/test/bench/shootout-threadring.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ fn roundtrip(id: int, n_tasks: int, p: &Port<int>, ch: &Chan<int>) {
}

fn main() {
use std::from_str::FromStr;

let args = if os::getenv("RUST_BENCH").is_some() {
~[~"", ~"2000000", ~"503"]
}
Expand Down