syntax: allow stmt/expr macro invocations to be delimited by {}. #12497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this proposal! 👍 |
|
👍 |
|
I'm looking forward to this. Can you add a compile-fail test to error out on |
This makes using control-flow-y macros like `spawn! { ... }` more fluent
and natural.
cc rust-lang#11892.
|
Done. |
|
mmh, I still think we could have avoided copying that error message around. +1 for this syntax improvement, though. |
|
There's quite a few places that have similar "expected x but found y" messages (and the messages aren't even consistent about "ident" vs. "identifier"); I imagine a clean-up patch that collects them together would be accepted. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
…atting-false-positive-when-commented-else, r=Alexendoo fix: `suspicious_else_formatting` false positive when else is included … This PR addresses an issue where invalid suggestions are generated for `if-else` formatting if comments contain the keyword `else`. The root of the problem is identified [here](https://github.com/rust-lang/rust-clippy/blob/95c62ffae9bbce793f68a6f1473e3fc24af19bdd/clippy_lints/src/formatting.rs#L217). Specifically, when a comment contains the word `else`, the lint mistakenly interprets it as part of an `if-else` clause. This misinterpretation leads to an incorrect splitting of the snippet, resulting in erroneous suggestions. fixes: rust-lang#12497 changelog: [`suspicious_else_formatting`]: Fixes invalid suggestions when comments include word else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes using control-flow-y macros like
spawn! { ... }more fluentand natural.
cc #11892.