tutorial: clearer explanation of freezing. #12536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Lending an immutable pointer" might be confusing. It was not discussed why borrowed pointers are immutable in the first place. - Make it clear that the borrowed pointers are immutable even if the variable was declared with `mut`. - Make it clear that we cannot even assign anything to the variable while its value is being borrowed.
| @@ -1468,14 +1468,14 @@ For a more in-depth explanation of references and lifetimes, read the | |||
|
|
|||
| ## Freezing | |||
|
|
|||
| Lending an immutable pointer to an object freezes it and prevents mutation. | |||
| Lending an &-pointer to an object freezes it and prevents mutation--even if the object was declared as `mut`. | |||
There was a problem hiding this comment.
I don't think the "mutation--even if" renders nicely.
Compare to how the em-dash after "of type point" renders (search for the text elsewhere in this document).
I.e. this:
- mutation--even if
- mutation—even if
|
@pnkfelix Thanks--changed it to an em-dash. :) |
|
@jagtalon great. Please squash the commits into one and then I will put the review mark on it. |
ghost
closed this
ghost
deleted the
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
`manual_assert`: do not add extra semicolon Fixes rust-lang#12505 changelog: [`manual_assert`]: do not add extra semicolon to suggestion
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mut.