Add more constants, functions, and tests for `f16` and `f128` by tgross35 · Pull Request #126608 · rust-lang/rust

tgross35 · 2024-06-17T20:14:23Z

This adds everything that was in some way blocked on const eval, since #126429 landed. There is a lot of cfg(bootstrap) since that is a fairly recent change.

f128 tests are disabled on everything except x86_64 and Linux aarch64, which are two platforms I know have "good" support for these types - meaning basic math symbols are available and LLVM doesn't hit selection crashes. f16 tests are enabled on almost everything except for known LLVM crashes. Doctests are only enabled on x86_64.

Tracking issue: #116909

rustbot · 2024-06-17T20:14:31Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35 · 2024-06-17T20:14:54Z

@rustbot author

tgross35 · 2024-06-18T04:07:47Z

@rustbot label +rla-silenced

tgross35 · 2024-06-18T04:15:19Z

Ah... guess the Clippy ICEs need to be fixed before this can be merged, #[allow(clippy)] still hits the ICE. Bit of an unfortunate sequence but I guess I need to fix that anyway.

library/core/src/num/f128.rs

bors · 2024-06-23T21:22:48Z

💔 Test failed - checks-actions

compiler-errors · 2024-06-23T21:25:20Z

@bors r- yeah it failed that rollup

tgross35 · 2024-06-24T00:32:59Z

I updated the x86 doctests to also be linux-only, which is what I meant to do originally

This will make it easier to keep `f16` and `f128` consistent as their implementations get added.

Better explain the reasoning for the `next_up`/`next_down` integer implementation, as requested by Ralf.

tgross35 · 2024-06-24T05:53:16Z

Had to disable f16 doctests on non-unix as well since it looks like extendhfsf/truncsfhf aren't always available. I was able to test locally on Windows MSVC and it passes there now.

@rustbot ready

There are some complexities about what platforms we can test f16 and f128 on. Put this in build.rs so we have an easy way to configure tests with a single attribute, and keep it up to date.

The symbols that these tests rely on are not available on all platforms and some ABIs are buggy, tests that rely on external functions are configured to only run on x86 (`f128`) or aarch64 (`f16`).

This adds everything that was directly or transitively blocked on const arithmetic for these types, which was recently merged. Since const arithmetic is recent, most of these need to be gated by `bootstrap`. Anything that relies on intrinsics that are still missing is excluded.

This suite tests all library functions that are now available for the types. Tests are only run on certain platforms where `f16` and `f128` are known to work (have symbols available and don't crash LLVM).

Mark-Simulacrum · 2024-06-25T18:56:39Z

@bors r+ rollup=never

bors · 2024-06-25T18:56:42Z

📌 Commit e181297 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2024-06-26T12:06:08Z

⌛ Testing commit e181297 with merge 4bdf8d2...

bors · 2024-06-26T14:21:24Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4bdf8d2 to master...

rust-timer · 2024-06-26T15:37:20Z

Finished benchmarking commit (4bdf8d2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.8%, secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.1%	[8.1%, 8.1%]	1
Improvements ✅ (primary)	-2.8%	[-3.4%, -2.2%]	2
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-2.8%	[-3.4%, -2.2%]	2

Cycles

Results (primary -1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 695.46s -> 694.171s (-0.19%)
Artifact size: 326.69 MiB -> 324.67 MiB (-0.62%)

rustbot assigned Mark-Simulacrum Jun 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 17, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2024

This comment has been minimized.

Sign in to view

tgross35 force-pushed the f16-f128-library branch from 7679706 to 6ac1622 Compare June 18, 2024 01:46

This comment has been minimized.

Sign in to view

rustbot added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Jun 18, 2024

tgross35 mentioned this pull request Jun 18, 2024

Bump nightly version -> 2024-06-17 rust-lang/rust-clippy#12952

Closed

tspiteri reviewed Jun 18, 2024

View reviewed changes

library/core/src/num/f128.rs Outdated Show resolved Hide resolved

tgross35 mentioned this pull request Jun 18, 2024

Resolve Clippy f16 and f128 unimplemented!/FIXMEs #126636

Merged

tgross35 force-pushed the f16-f128-library branch 13 times, most recently from 1f22545 to 6a8826e Compare June 19, 2024 00:21

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2024

tgross35 force-pushed the f16-f128-library branch 2 times, most recently from 88341ef to 7e617b0 Compare June 24, 2024 00:29

tgross35 force-pushed the f16-f128-library branch 2 times, most recently from 800427d to bc88716 Compare June 24, 2024 05:30

tgross35 mentioned this pull request Jun 24, 2024

Refactor float casting tests, add f16 and f128 rust-lang/miri#3688

Merged

tgross35 force-pushed the f16-f128-library branch from bc88716 to ff5da47 Compare June 24, 2024 05:41

tgross35 added 2 commits June 24, 2024 00:42

Extract repeated constants from f32 and f64 source

fce07a8

This will make it easier to keep `f16` and `f128` consistent as their implementations get added.

Reword docs for f32 and f64

0314fe6

Better explain the reasoning for the `next_up`/`next_down` integer implementation, as requested by Ralf.

tgross35 force-pushed the f16-f128-library branch from ff5da47 to ae50200 Compare June 24, 2024 05:42

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2024

tgross35 added 4 commits June 25, 2024 01:32

Add build.rs config for reliable f16 and f128

99ed3d3

There are some complexities about what platforms we can test f16 and f128 on. Put this in build.rs so we have an easy way to configure tests with a single attribute, and keep it up to date.

Add doctests to existing f16 and f128 functions

0eee055

The symbols that these tests rely on are not available on all platforms and some ABIs are buggy, tests that rely on external functions are configured to only run on x86 (`f128`) or aarch64 (`f16`).

Add tests for f16 and f128

e181297

This suite tests all library functions that are now available for the types. Tests are only run on certain platforms where `f16` and `f128` are known to work (have symbols available and don't crash LLVM).

martn3 mentioned this pull request Jul 2, 2024

std: Set has_reliable_f16 to false for MIPS targets in build.rs #127235

Merged

Uh oh!

Conversation

tgross35 commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 17, 2024

Uh oh!

tgross35 commented Jun 17, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tgross35 commented Jun 18, 2024

Uh oh!

tgross35 commented Jun 18, 2024

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Jun 23, 2024

Uh oh!

compiler-errors commented Jun 23, 2024

Uh oh!

tgross35 commented Jun 24, 2024

Uh oh!

tgross35 commented Jun 24, 2024

Uh oh!

Mark-Simulacrum commented Jun 25, 2024

Uh oh!

bors commented Jun 25, 2024

Uh oh!

bors commented Jun 26, 2024

Uh oh!

bors commented Jun 26, 2024

Uh oh!

rust-timer commented Jun 26, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tgross35 commented Jun 17, 2024 •

edited

Loading