Improve std::char doc #12759
Merged
Improve std::char doc #12759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //! as it can contain any Unicode code point except high-surrogate and | ||
| //! low-surrogate code points. | ||
| //! | ||
| //! As such, only values in the ranges \[0x0,0xD7FF16\] and \[0xE00016,0x10FFFF16\] |
There was a problem hiding this comment.
I think the trailing 16 is incorrect.
This seems to be causing some confusion among users. Rust's char are not 8bit characters, but 32bit UCS-4 codepoint without surrogates (Unicode Scalar Values as per Unicode glossary). Make the doc more explicit about it. Signed-off-by: Luca Bruno <[email protected]>
Uniform and beautify doc-string for current rustdoc output. Signed-off-by: Luca Bruno <[email protected]>
XID_* property are defined in UAX #31, just reference it here. Signed-off-by: Luca Bruno <[email protected]>
|
Thanks for the the review, all comments addressed and branch rebased. Moreover, this was failing |
bors
added a commit
that referenced
this pull request
Mar 9, 2014
This is mostly a reaction to #12730. If we are going to keep calling them `char`, at least make it clear that they aren't characters but codepoint/scalar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a reaction to #12730. If we are going to keep calling them
char, at least make it clear that they aren't characters but codepoint/scalar.