Stop using MoveDataParamEnv for places that don't need a param-env#128153
Stop using MoveDataParamEnv for places that don't need a param-env#128153bors merged 1 commit intorust-lang:masterfrom
MoveDataParamEnv for places that don't need a param-env#128153Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
|
R=me after rebase |
|
@bors r=cjgillot rollup |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126247 (rustdoc: word wrap CamelCase in the item list table and sidebar) - rust-lang#128104 (Not lint pub structs without pub constructors intentionally) - rust-lang#128153 (Stop using `MoveDataParamEnv` for places that don't need a param-env) - rust-lang#128284 (Stabilize offset_of_nested) - rust-lang#128342 (simplify the use of `CiEnv`) - rust-lang#128355 (triagebot: make sure Nora is called Nora) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128153 - compiler-errors:mdpe, r=cjgillot Stop using `MoveDataParamEnv` for places that don't need a param-env I think not threading through a `ParamEnv` makes it clearer that these functions don't do anything particularly "type systems"-y. r? cjgillot
|
@rust-timer build 2979c42 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (2979c42): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 4.5%, secondary 3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 769.793s -> 769.839s (0.01%) |
I think not threading through a
ParamEnvmakes it clearer that these functions don't do anything particularly "type systems"-y.r? cjgillot