Use Vec in instantiate_binder_with_fresh_vars

[Bryanskiy]

FxHashMap was replaced with a pre-computed Vec of infer vars.

r? @lcnr

[Bryanskiy]

@rustbot author

[Bryanskiy]

@rustbot ready

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 8a5efd1 with merge a460351...

[bors]

☀️ Try build successful - checks-actions
Build commit: a460351 (a460351ddc2bda230fde02137ff3b2568e8fd6b7)

[rust-timer]

Finished benchmarking commit (a460351): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.3%, secondary 5.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	5.8%	[5.7%, 5.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.3%	[3.3%, 3.3%]	1

Cycles

Results (primary -2.2%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.4%, -2.0%]	3
Improvements ✅ (secondary)	-2.1%	[-2.6%, -1.6%]	4
All ❌✅ (primary)	-2.2%	[-2.4%, -2.0%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.493s -> 770.438s (0.25%)
Artifact size: 331.80 MiB -> 331.68 MiB (-0.04%)

[lcnr]

thanks

@bors r+

[bors]

📌 Commit 8a5efd1 has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8a5efd1 with merge e69c19e...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing e69c19e to master...

[rust-timer]

Finished benchmarking commit (e69c19e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 4.5%, secondary 5.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.5%	[4.5%, 4.5%]	1
Regressions ❌ (secondary)	5.6%	[5.4%, 5.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.5%	[4.5%, 4.5%]	1

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.701s -> 770.079s (0.18%)
Artifact size: 331.89 MiB -> 331.86 MiB (-0.01%)