[EXPERIMENTAL] try a workaround for unstable error message order#128505
Closed
folkertdev wants to merge 8 commits intorust-lang:masterfrom
Closed
[EXPERIMENTAL] try a workaround for unstable error message order#128505folkertdev wants to merge 8 commits intorust-lang:masterfrom
folkertdev wants to merge 8 commits intorust-lang:masterfrom
Conversation
Previously these would be treated like integer literals and default to `i32` if a type could not be determined. To allow for forward-compatibility with `str` constants in the future, this PR changes type inference to use an unbound type variable instead. The actual type checking is deferred until after typeck where we still ensure that the final type for the `const` operand is an integer type.
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
asm-const-split-test-file
branch
from
08c8887 to
8fd7cc9
Compare
Contributor
Author
|
this has served its purpose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #125558 we're running into error messages being printed in a different order on different machines. This PR tries to separate the tests into multiple files, so hopefully that is no longer a problem. Not a great solution, but it would get us unstuck.
r? @ghost