bootstrap minor improvements and clean-ups #128588
Conversation
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
| // FIXME: cargo bench/install do not accept `--release` | ||
| // and miri doesn't want it |
There was a problem hiding this comment.
This doesn't seem like a FIXME note; it's more like a regular note.
| // FIXME: tool_std is not quite right, we shouldn't allow nightly features. | ||
| // But `builder.cargo` doesn't know how to handle ToolBootstrap in stages other than 0, | ||
| // and this is close enough for now. | ||
| Rls, "src/tools/rls", "rls", stable=true, tool_std=true; |
There was a problem hiding this comment.
This is an outdated FIXME we had for rust-demangler.
| // FIXME: maybe we should do this for download-rustc as well? but it would be a pain to update | ||
| // this on each and every nightly ... |
There was a problem hiding this comment.
It sounds painful and I think we will never be doing this.
There was a problem hiding this comment.
For a future possibility, maybe distribute the hashes with the tarballs?
Or resurrect the signing of the artifacts...
|
☔ The latest upstream changes (presumably #128534) made this pull request unmergeable. Please resolve the merge conflicts. |
onur-ozkan
force-pushed
the
clean-up-bootstrap-internals
branch
from
ff022f1 to
8d7c374
Compare
Signed-off-by: onur-ozkan <[email protected]>
|
Rebased. |
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
| // FIXME: maybe we should do this for download-rustc as well? but it would be a pain to update | ||
| // this on each and every nightly ... |
There was a problem hiding this comment.
For a future possibility, maybe distribute the hashes with the tarballs?
Or resurrect the signing of the artifacts...
|
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5601d14): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 749.361s -> 748.109s (-0.17%) |
3rd commit fixes #128553 (comment).