Add implementations for `unbounded_shl`/`unbounded_shr` #129377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bors merged 8 commits into rust-lang:master from chorman0773:unbounded-shifts-impl

Aug 26, 2024

Contributor

chorman0773 commented Aug 21, 2024

Tracking Issue: #129375

This implements unbounded_shl and unbounded_shr under the feature gate unbounded_shifts


          feat(core): Add implementations for unbounded_shl/unbounded_shr

9b5a004

rustbot assigned scottmcm

Collaborator

rustbot commented Aug 21, 2024

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review T-libs labels

chorman0773 mentioned this pull request

Tracking Issue for unbounded_shifts #129375

Open

3 tasks

chorman0773 changed the title ~~feat(core): Add implementations for unbounded_shl/unbounded_shr~~ Add implementations for unbounded_shl/unbounded_shr

This comment has been minimized.

Sign in to view

Noratrieb reviewed

View reviewed changes

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved


          Manually format functions and use rhs instead of v from my CE tes…

c89bae0

…ting

This comment has been minimized.

Sign in to view


          chore: Also format the control flow

38b5a2a

scottmcm reviewed

View reviewed changes

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

scottmcm requested changes

View reviewed changes

Member

scottmcm left a comment

Not sure if github will hide it, since it looks like I raced with one of your updates, but I have a suggestion in #129377

rustbot added S-waiting-on-author and removed S-waiting-on-review labels

This comment has been minimized.

Sign in to view


          chore: x fmt and hopefully fix the tidy issue

79cbb87

This comment has been minimized.

Sign in to view


          fix(core): Add #![feature(unbounded_shifts)] to doctests for `unbou…

9907f61

…nded_shr`/`unbounded_shl`

This comment has been minimized.

Sign in to view


          chore: x fmt

27b63b8

This comment has been minimized.

Sign in to view


          fix(core): Use correct operations/values in unbounded_shr doctests

2cf48ea

chorman0773 requested a review from scottmcm

August 22, 2024 03:03

rustbot added S-waiting-on-review and removed S-waiting-on-author labels

Contributor Author

chorman0773 commented Aug 22, 2024

Also, don't know whether I need to do this now, but rustc-dev-guide apparently wants this for new rustc_allow_const_fn_unstable uses, so CC: @rust-lang/wg-const-eval.

scottmcm reviewed

View reviewed changes

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved


          feat(core): Make unbounded_shl{l,r} unstably const and remove `rust…

f4dc783

…c_allow_const_fn_unstable`

RalfJung mentioned this pull request

clarify the role of rustc_const_unstable rust-lang/rustc-dev-guide#2045

Merged

chorman0773 requested a review from scottmcm

August 24, 2024 14:10

Member

scottmcm commented Aug 26, 2024

Thanks! I'm glad to have these, since I think they're the only good shifts :)

@bors r+ rollup

Collaborator

bors commented Aug 26, 2024

📌 Commit f4dc783 has been approved by scottmcm

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

matthiaskrgr mentioned this pull request

Rollup of 7 pull requests #129615

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129615 - matthiaskrgr:rollup-lw733x7, r=matth…

0fccd9d

…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
 - rust-lang#129377 (Add implementations for `unbounded_shl`/`unbounded_shr`)
 - rust-lang#129539 (link to Future::poll from the Poll docs)
 - rust-lang#129588 (pal/hermit: correctly round up microseconds in `Thread::sleep`)
 - rust-lang#129592 (Remove cfg(test) from library/core)
 - rust-lang#129597 (mv `build_reduced_graph_for_external_crate_res` into Resolver)
 - rust-lang#129600 (Tie `impl_trait_overcaptures` lint to Rust 2024)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129615 - matthiaskrgr:rollup-lw733x7, r=matth…

515395a

…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
 - rust-lang#129377 (Add implementations for `unbounded_shl`/`unbounded_shr`)
 - rust-lang#129539 (link to Future::poll from the Poll docs)
 - rust-lang#129588 (pal/hermit: correctly round up microseconds in `Thread::sleep`)
 - rust-lang#129592 (Remove cfg(test) from library/core)
 - rust-lang#129597 (mv `build_reduced_graph_for_external_crate_res` into Resolver)
 - rust-lang#129600 (Tie `impl_trait_overcaptures` lint to Rust 2024)

r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit 68aff29 into rust-lang:master

6 checks passed

rustbot added this to the 1.82.0 milestone

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#129377

c7c44bb

Rollup merge of rust-lang#129377 - chorman0773:unbounded-shifts-impl, r=scottmcm

Add implementations for `unbounded_shl`/`unbounded_shr`

Tracking Issue: rust-lang#129375

This implements `unbounded_shl` and `unbounded_shr` under the feature gate `unbounded_shifts`

RalfJung mentioned this pull request

Update const-stability rules because we're not in min-const-fn times any more #129815

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-libs