Adding logic to the configuration help script to take default values into account #130125
Conversation
Initial approach
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @onur-ozkan (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
| o("local-rust", None, "use an installed rustc rather than downloading a snapshot") | ||
| o("debug", "rust.debug", "enables debugging environment; does not affect optimization of bootstrapped code", default=False) | ||
| o("docs", "build.docs", "build standard library documentation", default=True) | ||
| o("compiler-docs", "build.compiler-docs", "build compiler documentation", default=False) |
There was a problem hiding this comment.
If this prints --disable-docs, then the current description afterwards must be negated. E.g. to "skip building compiler documentation".
| o("local-rebuild", "build.local-rebuild", "assume local-rust matches the current version, for rebuilds; implies local-rust, and is implied if local-rust already matches the current version", default=False) | ||
| o("llvm-static-stdcpp", "llvm.static-libstdcpp", "statically link to libstdc++ for LLVM", default=False) | ||
| o("llvm-link-shared", "llvm.link-shared", "prefer shared linking to LLVM (llvm-config --link-shared)", default=False) | ||
| o("rpath", "rust.rpath", "build rpaths into rustc itself", default=False) | ||
| o("codegen-tests", "rust.codegen-tests", "run the tests/codegen tests", default=False) | ||
| o("ninja", "llvm.ninja", "build LLVM using the Ninja generator (for MSVC, requires building in the correct environment)", default=False) |
There was a problem hiding this comment.
This is so unmaintainable approach. We can't track these default values unfortunately.
onur-ozkan
added
S-waiting-on-author
|
Hi, I thought so too. This was more of a way to demonstrate this very issue. |
No description provided.