Skip to content

rustdoc: fix and re-enable help widget on mobile #130445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lolbinarycat
Copy link
Contributor

fixes #77899

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Sep 16, 2024

It'll be fixed by #129545. I don't think it's a good idea to make changes (for the help menu on mobile) before this one is merged.

@lolbinarycat
Copy link
Contributor Author

ah, i wasn't aware of that PR, i assumed that no progress was being made on the issue since it was 4 years old.

@GuillaumeGomez
Copy link
Member

Ah we didn't link to it, good point! Gonna update the PR so it mentions the issue.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
.......... (130/131)
F          (131/131)


/checkout/tests/rustdoc-gui/scrape-examples-layout.goml scrape-examples-layout... FAILED
[ERROR] `tests/rustdoc-gui/scrape-examples-layout.goml` line 85: The following errors happened: [different Y values: 288 (or 288) != 284]: for command `assert-position: (".scraped-example", {"y": 284})`
[ERROR] `tests/rustdoc-gui/scrape-examples-layout.goml` line 86: The following errors happened: [different Y values: 316 (or 316) != 312]: for command `assert-position: (".scraped-example .prev", {"y": 284 + |offset_y| + |title_height|})`
Error: ()
Build completed unsuccessfully in 0:03:12
  local time: Mon Sep 16 21:26:29 UTC 2024
  network time: Mon, 16 Sep 2024 21:26:29 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: help widget oversized on mobile and can't scroll
4 participants