refactor bootstrap path resolution #135058
Merged
+76
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we removed paths as soon as we found the first intersection, which made it impossible to find other intersecting paths. This patch changes that by marking the intersecting paths instead, so we can collect them all and remove them together when needed. Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
…emble`" This reverts commit 552c1f5.
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
jieyouxu
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Thanks for the fix. To make sure I properly understand the intention:
- whereas previously the run logic adopted a "first matching
Stepconsumes path filter" scheme, - now the run logic adopt a "all matching
Steps will be executed" scheme.
Is my description accurate?
EDIT: it seems so.
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
Yes, it is accurate. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 3, 2025
…ouxu refactor bootstrap path resolution Previously we removed paths as soon as we found the first intersection, which made it impossible to find other intersecting paths (and that is the reason of rust-lang#135022). This patch changes that by marking the intersecting paths instead, so we can collect them all and remove them together when needed. Which means, `x build compiler` would compile anything that ends or starts with `"compiler"` instead of picking the first matching `Step` from `builder::get_step_descriptions`. Fixes rust-lang#135022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#133420 (Switch rtems target to panic unwind) - rust-lang#134965 (Make Boxy UwU) - rust-lang#135007 (Some type-outlives computation tweaks) - rust-lang#135036 (run-make-support: adjust assertion printing, add some basic sanity checks) - rust-lang#135043 (rustdoc: treat `allowed_through_unstable_modules` as deprecation) - rust-lang#135044 (Improve infer (`_`) suggestions in `const`s and `static`s) - rust-lang#135058 (refactor bootstrap path resolution) - rust-lang#135061 (crashes: add latest batch of tests) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133420 (Switch rtems target to panic unwind) - rust-lang#134965 (Make Boxy UwU) - rust-lang#135007 (Some type-outlives computation tweaks) - rust-lang#135036 (run-make-support: adjust assertion printing, add some basic sanity checks) - rust-lang#135043 (rustdoc: treat `allowed_through_unstable_modules` as deprecation) - rust-lang#135044 (Improve infer (`_`) suggestions in `const`s and `static`s) - rust-lang#135058 (refactor bootstrap path resolution) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2025
Rollup merge of rust-lang#135058 - onur-ozkan:path-resolution, r=jieyouxu refactor bootstrap path resolution Previously we removed paths as soon as we found the first intersection, which made it impossible to find other intersecting paths (and that is the reason of rust-lang#135022). This patch changes that by marking the intersecting paths instead, so we can collect them all and remove them together when needed. Which means, `x build compiler` would compile anything that ends or starts with `"compiler"` instead of picking the first matching `Step` from `builder::get_step_descriptions`. Fixes rust-lang#135022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we removed paths as soon as we found the first intersection, which made it impossible to find other intersecting paths (and that is the reason of #135022).
This patch changes that by marking the intersecting paths instead, so we can collect them all and remove them together when needed. Which means,
x build compilerwould compile anything that ends or starts with"compiler"instead of picking the first matchingStepfrombuilder::get_step_descriptions.Fixes #135022