-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Prepare Rust 1.84.0 stable release #135162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When `-Cstrip` was changed to use the bundled rust-objcopy instead of /usr/bin/strip on OSX, strip-like arguments were preserved. But strip and objcopy are, while being the same binary, different, they have different defaults depending on which binary they are. Notably, strip strips everything by default, and objcopy doesn't strip anything by default. Additionally, `-S` actually means `--strip-all`, so debuginfo stripped everything and symbols didn't strip anything. We now correctly pass `--strip-debug` and `--strip-all`.
This PR modifies cc @jieyouxu |
@bors r+ p=1000 rollup=never |
Prepare Rust 1.84.0 stable release Included a backport of rust-lang#135034, and squashed the release notes. r? `@ghost`
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
💔 Test failed - checks-actions |
@bors retry Seems like a spurious failure. |
Prepare Rust 1.84.0 stable release Included a backport of rust-lang#135034, and squashed the release notes. r? `@ghost`
Miri is deterministic (but in a way that behavior can still change with basically arbitrary changes anywhere in the sysroot), so this will likely repeat. I didn't know that this even runs for stable... This is failing for aarch64-apple-darwin, so as @jieyouxu noted indeed an instance of #133421. I haven't yet exactly figured out which test, but backporting #133435 might help. EDIT: the test is |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Seems like the Windows file locking/removal spurious error again. @bors retry |
☀️ Test successful - checks-actions |
Is there an issue tracking that problem? As far as I can tell, hardly anyone is even aware of this problem. |
OK, that's coming for 1.86, which is the main thing I wanted to know -- thanks! |
Included a backport of #135034, and squashed the release notes.
r? @ghost