Skip to content

re-add a warning for old master branch, but with much simpler logic #135301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2025
Merged

re-add a warning for old master branch, but with much simpler logic #135301

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1772e7
re-add a warning for old master branch, but with much simpler logic
lolbinarycat Jan 9, 2025
60cbd74
never print the warning on CI
lolbinarycat Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/bootstrap/src/core/build_steps/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ fn print_paths(verb: &str, adjective: Option<&str>, paths: &[String]) {
} else {
println!("fmt: {verb} {len} {adjective}files");
}
if len > 1000 {
println!("hint: if this number seems too high, try running `git fetch origin master");
}
Copy link
Contributor

@onur-ozkan onur-ozkan Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the if here should include "not a CI" check as we are not interested on this for CI environments.

}

pub fn format(build: &Builder<'_>, check: bool, all: bool, paths: &[PathBuf]) {
Expand Down
Loading