Do not assume const params are printed after type params #135749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
|
This code seriously un-jank-ifies the printing logic for type mismatches. |
fbstj
reviewed
Jan 20, 2025
Comment on lines
728
to
730
| if !args.is_empty() { | ||
| value.push_highlighted("<"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !args.is_empty() { | |
| value.push_highlighted("<"); | |
| } | |
| if args.is_empty() { | |
| return; | |
| } | |
| value.push_highlighted("<"); |
compiler-errors
force-pushed
the
param-ordering
branch
from
b45a8c4 to
97e07da
Compare
|
@bors r=davidtwco rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135415 (Add `File already exists` error doc to `hard_link` function) - rust-lang#135581 (Separate Builder methods from tcx) - rust-lang#135728 (document order of items in iterator from drain) - rust-lang#135749 (Do not assume const params are printed after type params) - rust-lang#135829 (Rustc dev guide subtree update) - rust-lang#135938 (Add memory layout documentation to generic NonZero<T>) - rust-lang#135949 (Use short type string in E0308 secondary span label) - rust-lang#135976 (Don't drop types with no drop glue when building drops for tailcalls) - rust-lang#135998 ([rustdoc] Fix indent of trait items on mobile) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 25, 2025
Rollup merge of rust-lang#135749 - compiler-errors:param-ordering, r=davidtwco Do not assume const params are printed after type params Fixes rust-lang#135737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135737