retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features #135927
+244
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_gcc |
azhogin
force-pushed
the
azhogin/retpoline
branch
from
e808e83 to
12b286f
Compare
This comment has been minimized.
This comment has been minimized.
|
r? compiler |
This comment was marked as resolved.
This comment was marked as resolved.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
12b286f to
f331c60
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
f331c60 to
434a25f
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
434a25f to
945d0f1
Compare
This comment has been minimized.
This comment has been minimized.
|
r? compiler |
azhogin
force-pushed
the
azhogin/retpoline
branch
from
945d0f1 to
0ea46d2
Compare
This comment has been minimized.
This comment has been minimized.
|
r? compiler |
azhogin
force-pushed
the
azhogin/retpoline
branch
from
0ea46d2 to
386c90e
Compare
|
r? @davidtwco maybe 😅 |
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
d70fbca to
b6ecdc1
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
b6ecdc1 to
203cb50
Compare
26 tasks
|
@rustbot labels -S-waiting-on-MCP Looks like we're no longer waiting on the MCP here: |
rustbot
removed
the
S-waiting-on-MCP
|
@azhogin: Are you ready for this to be reviewed? If so, mark it with |
This comment was marked as resolved.
This comment was marked as resolved.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
203cb50 to
8d6ef02
Compare
azhogin
force-pushed
the
azhogin/retpoline
branch
from
8d6ef02 to
0321253
Compare
rustbot
added
the
A-LLVM
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
0321253 to
99ece33
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/retpoline
branch
from
99ece33 to
14f651e
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
…o enable retpoline-related target features
azhogin
force-pushed
the
azhogin/retpoline
branch
from
14f651e to
5601490
Compare
davidtwco
approved these changes
Jun 12, 2025
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2025
…twco retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features `-Zretpoline` and `-Zretpoline-external-thunk` flags are target modifiers (tracked to be equal in linked crates). * Enables target features for `-Zretpoline-external-thunk`: `+retpoline-external-thunk`, `+retpoline-indirect-branches`, `+retpoline-indirect-calls`. * Enables target features for `-Zretpoline`: `+retpoline-indirect-branches`, `+retpoline-indirect-calls`. It corresponds to clang -mretpoline & -mretpoline-external-thunk flags. Also this PR forbids to specify those target features manually (warning). Issue: rust-lang#116852
bors
added a commit
that referenced
this pull request
Jun 13, 2025
Rollup of 9 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - #140770 (add `extern "custom"` functions) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142248 (Add supported asm types for LoongArch32) - #142267 (assert more in release in `rustc_ast_lowering`) - #142274 (Update the stdarch submodule) - #142276 (Update dependencies in `library/Cargo.lock`) - #142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - #140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Zretpolineand-Zretpoline-external-thunkflags are target modifiers (tracked to be equal in linked crates).-Zretpoline-external-thunk:+retpoline-external-thunk,+retpoline-indirect-branches,+retpoline-indirect-calls.-Zretpoline:+retpoline-indirect-branches,+retpoline-indirect-calls.It corresponds to clang -mretpoline & -mretpoline-external-thunk flags.
Also this PR forbids to specify those target features manually (warning).
Issue: #116852