Instantiate predicate binder without recanonicalizing goal in new solver #136997
+91
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
reviewed
Feb 14, 2025
| @@ -28,5 +29,5 @@ impl<V> Trait<u16, V> for () {} | |||
| fn impls_trait<T: Trait<U, V>, U: Id<V>, V>() {} | |||
| fn main() { | |||
| impls_trait::<(), _, _>() | |||
| //~^ ERROR type annotations needed | |||
| //[old]~^ ERROR type annotations needed | |||
There was a problem hiding this comment.
this test should be changed to have one step of indirection between the binder and the LeakCheckFailure bound.
|
hmm 👍 one concern is that this also impacts coherence, so it affects stable. would need an FCP (and it seems generally useful to explain this to the other types team members, if only to fully reason about this ourselves). I would be fine writing the FCP comment, but would finish some other work first, so it'd take a while |
|
☔ The latest upstream changes (presumably #139595) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the side-effect of making the leak check stronger.
r? lcnr