Skip to content

Bump to version 1.87.0 #137034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Bump to version 1.87.0 #137034

merged 1 commit into from
Feb 16, 2025

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Feb 14, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Feb 14, 2025
@cuviper
Copy link
Member Author

cuviper commented Feb 14, 2025

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

📌 Commit e4f539e has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
@bors
Copy link
Collaborator

bors commented Feb 14, 2025

⌛ Testing commit e4f539e with merge 381bc55...

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sdb1       147G  4.1G  136G   3% /mnt
tmpfs           1.6G  4.0K  1.6G   1% /run/user/1001
================================================================================

Failed to stop mysql.service: Unit mysql.service not loaded.
##[error]Process completed with exit code 5.

@cuviper
Copy link
Member Author

cuviper commented Feb 14, 2025

@bors retry
(after #137041)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
@bors
Copy link
Collaborator

bors commented Feb 15, 2025

⌛ Testing commit e4f539e with merge 83638d3...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-distcheck failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test result: FAILED. 72 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 37.80s

error: test failed, to rerun pass `--lib`
Build completed unsuccessfully in 1:05:31
make: *** [Makefile:49: check] Error 1
Command has failed. Rerun with -v to see more details.
  local time: Sat Feb 15 04:51:00 UTC 2025
  network time: Sat, 15 Feb 2025 04:51:00 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented Feb 15, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2025
@cuviper
Copy link
Member Author

cuviper commented Feb 15, 2025

  ---- core::builder::tests::test_prebuilt_llvm_config_path_resolution stdout ----
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `arm-linux-gnueabihf-gcc` installed?
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `arm-linux-gnueabihf-gcc` installed?
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `arm-linux-gnueabihf-g++` installed?
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `arm-linux-gnueabihf-g++` installed?
  Detected LLVM as non-available: running in CI and modified LLVM in this change
  
  thread 'core::builder::tests::test_prebuilt_llvm_config_path_resolution' panicked at src/bootstrap/src/core/builder/tests.rs:1066:5:
  assertion `left == right` failed
    left: "/checkout/obj/build/tmp/distcheck/build/tmp-dry-run/x86_64-unknown-linux-gnu/ci-llvm/bin/llvm-config"
   right: "/checkout/obj/build/tmp/distcheck/build/tmp-dry-run/x86_64-unknown-linux-gnu/llvm/bin/llvm-config"

@onur-ozkan any idea why this failed? Is it perhaps overly sensitive to the version number?

@onur-ozkan
Copy link
Member

onur-ozkan commented Feb 15, 2025

Bootstrap switches to in-tree LLVM when CI one is not available. It seems that covering CI LLVM is not a good idea in that test. Feel free to remove that part from the test.

Can you confirm that #137066 fixes this?

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2025
check if CI-LLVM is enabled before testing it

Blocker for rust-lang#137034
@cuviper
Copy link
Member Author

cuviper commented Feb 15, 2025

Can you confirm that #137066 fixes this?

Since that one is now under testing, I'll wait for it to merge and then try again. Thanks for the quick response!

@cuviper
Copy link
Member Author

cuviper commented Feb 15, 2025

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 15, 2025
@bors
Copy link
Collaborator

bors commented Feb 15, 2025

⌛ Testing commit e4f539e with merge e72df78...

@bors
Copy link
Collaborator

bors commented Feb 16, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing e72df78 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2025
@bors bors merged commit e72df78 into rust-lang:master Feb 16, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 16, 2025
@cuviper cuviper deleted the version-1.87.0 branch February 16, 2025 03:50
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e72df78): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.7% [0.7%, 0.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 789.619s -> 790.103s (0.06%)
Artifact size: 350.04 MiB -> 350.03 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants