Generalize stats from f64 to the Float trait #13822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,7 +184,8 @@ impl<'a> Stats for &'a [f64] { | |||
| // `lo`. Together `hi+lo` are exactly equal to `x+y`. | |||
| let hi = x + y; | |||
| let lo = y - (hi - x); | |||
| if lo != 0f64 { | |||
| let zero: T = Zero::zero(); | |||
| if lo != zero { | |||
|
Are there other problems? |
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
internal: Pass `FamousDefs` around in inlay hints Bind after at go brrrrr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attempt to generalize stats, after #12606.
Since #12355 did not get merged, i want go get first get my change done and the try to fix sum.