[do not merge] Preparation for LLD stabilization #138645

Kobzol · 2025-03-18T07:19:49Z

This PR serves for testing test changes for stabilizing LLD.

try-job: dist-x86_64-linux

Kobzol · 2025-03-18T21:30:38Z

[do not merge] Preparation for LLD stabilization This PR serves for testing test changes for stabilizing LLD. CC `@lqd` r? `@ghost` try-job: dist-x86_64-linux

bors · 2025-03-18T21:31:50Z

⌛ Trying commit 80cbbeb with merge 8a4821f...

bors · 2025-03-19T00:01:31Z

☀️ Try build successful - checks-actions
Build commit: 8a4821f (8a4821f34179797445396b9696f039281dd55f84)

compiler/rustc_session/src/config.rs

bors · 2025-03-25T20:56:38Z

☔ The latest upstream changes (presumably #138865) made this pull request unmergeable. Please resolve the merge conflicts.

…eyouxu Add helper function for checking LLD usage to `run-make-support` Extracted out of rust-lang#138645, should be a simple refactoring. r? `@jieyouxu`

…eyouxu Add helper function for checking LLD usage to `run-make-support` Extracted out of rust-lang#138645, should be a simple refactoring. r? ``@jieyouxu``

Rollup merge of rust-lang#139322 - Kobzol:run-make-lld-refactor, r=jieyouxu Add helper function for checking LLD usage to `run-make-support` Extracted out of rust-lang#138645, should be a simple refactoring. r? ``@jieyouxu``

bors · 2025-04-04T12:53:52Z

☔ The latest upstream changes (presumably #139354) made this pull request unmergeable. Please resolve the merge conflicts.

src/doc/rustc/src/codegen-options/index.md

lqd · 2025-04-04T20:25:02Z

Might as well @bors try

bors · 2025-04-04T20:26:14Z

⌛ Trying commit 49cabaa with merge 0c623eb...

[do not merge] Preparation for LLD stabilization This PR serves for testing test changes for stabilizing LLD. CC `@lqd` r? `@ghost` try-job: dist-x86_64-linux

bors · 2025-04-04T22:56:27Z

☀️ Try build successful - checks-actions
Build commit: 0c623eb (0c623eb581ae54ed553869852e1d1b3bf0bb6a82)

And remove the previous beta/stable/nightly LLD tests.

…rget without -Zunstable-options

…+]lld` - separate enabling and disabling the feature in the error - add both polarities to the dedicated test - update documentation and precondition

…atures` - to show the enabled and disabled unstable features in the error

move the unstable `-Clinker-features` documentation to the stable book, as there's only a single feature, and it is now stable

now that it's been stabilized, beta and stage1 need to use different flags (-C vs -Z)

lqd · 2025-04-25T15:55:55Z

@bors try

[do not merge] Preparation for LLD stabilization This PR serves for testing test changes for stabilizing LLD. CC `@lqd` r? `@ghost` try-job: dist-x86_64-linux

bors · 2025-04-25T15:57:08Z

⌛ Trying commit 5d920a3 with merge f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a...

rust-log-analyzer · 2025-04-25T16:15:23Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
##[group]Building compiler artifacts (stage1 -> stage2, x86_64-unknown-linux-gnu)
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg -Wwarnings` (exit status: 1)
  --- stderr
  error: unknown unstable option: `linker-features`

  [RUSTC-TIMING] ___ test:false 0.010
Build completed unsuccessfully in 0:07:50
---
Caused by:
    Command RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --rust-profile-generate /tmp/tmp-multistage/opt-artifacts/rustc-pgo --set llvm.thin-lto=false --set llvm.link-shared=true [at /checkout/obj] has failed with exit code Some(1)

Stack backtrace:
   0: <anyhow::Error>::msg::<alloc::string::String>
             at /rust/deps/anyhow-1.0.97/src/backtrace.rs:27:14
   1: <opt_dist::exec::CmdBuilder>::run
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/exec.rs:80:17
   2: <opt_dist::exec::Bootstrap>::run
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/exec.rs:181:9
   3: opt_dist::execute_pipeline::{closure#1}::{closure#0}
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/main.rs:230:13
   4: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}::{closure#0}, ()>
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/timer.rs:111:22
   5: opt_dist::execute_pipeline::{closure#1}
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/main.rs:219:9
   6: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}, opt_dist::training::RustcPGOProfile>
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/timer.rs:111:22
   7: opt_dist::execute_pipeline
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/main.rs:216:29
   8: opt_dist::main
             at /rustc/f88e20107e2356d368ffcc8c3e225e7e7e1f6d4a/src/tools/opt-dist/src/main.rs:416:18
   9: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/45165c82a4c5315ff52c391ad138f41ff40b52d8/library/core/src/ops/function.rs:250:5
  10: std::sys::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
             at /rustc/45165c82a4c5315ff52c391ad138f41ff40b52d8/library/std/src/sys/backtrace.rs:152:18
  11: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
             at /rustc/45165c82a4c5315ff52c391ad138f41ff40b52d8/library/std/src/rt.rs:199:18
  12: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/45165c82a4c5315ff52c391ad138f41ff40b52d8/library/core/src/ops/function.rs:284:13
  13: std::panicking::try::do_call
             at /rustc/45165c82a4c5315ff52c391ad138f41ff40b52d8/library/std/src/panicking.rs:589:40
  14: std::panicking::try
             at /rustc/45165c82a4c5315ff52c391ad138f41ff40b52d8/library/std/src/panicking.rs:552:19

bors · 2025-04-25T16:15:36Z

💔 Test failed - checks-actions

This comment has been minimized.

Sign in to view

Kobzol force-pushed the stabilize-lld-test branch from 549454f to 80cbbeb Compare March 18, 2025 07:30

Kobzol force-pushed the stabilize-lld-test branch 3 times, most recently from 24fc786 to fd52515 Compare March 19, 2025 16:34

This comment has been minimized.

Sign in to view

Kobzol force-pushed the stabilize-lld-test branch from fd52515 to 94b7099 Compare March 19, 2025 16:47

lqd reviewed Mar 19, 2025

View reviewed changes

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

Kobzol force-pushed the stabilize-lld-test branch from 94b7099 to a4eb811 Compare March 19, 2025 18:57

Kobzol force-pushed the stabilize-lld-test branch from c8d2fe7 to 2cb937d Compare April 3, 2025 12:54

This comment has been minimized.

Sign in to view

Kobzol force-pushed the stabilize-lld-test branch from 2cb937d to 77fb451 Compare April 3, 2025 13:39

Kobzol mentioned this pull request Apr 3, 2025

Add helper function for checking LLD usage to run-make-support #139322

Merged

lqd self-assigned this Apr 4, 2025

lqd force-pushed the stabilize-lld-test branch from 77fb451 to 75587e7 Compare April 4, 2025 14:00

Kobzol commented Apr 4, 2025

View reviewed changes

src/doc/rustc/src/codegen-options/index.md Outdated Show resolved Hide resolved

Kobzol commented Apr 4, 2025

View reviewed changes

src/doc/rustc/src/codegen-options/index.md Outdated Show resolved Hide resolved

lqd force-pushed the stabilize-lld-test branch from cf94827 to 49cabaa Compare April 4, 2025 18:47

Kobzol and others added 16 commits April 25, 2025 15:48

Use LLD by default on x64 regardless of channel

ce48c91

Add post-dist test for checking that we use LLD

9a57274

And remove the previous beta/stable/nightly LLD tests.

Move -Zlinker-features to -Clinker-features

8f0ae0e

Check that -Clinker-features=[-+]lld can be used only on the x64 ta…

62c4633

…rget without -Zunstable-options

Stabilize -Clink-self-contained=[+-]linker

b38cf22

Add test for unstable values of -Clink-self-contained

80e7999

Update documentation

4411b52

update bootstrap comment

6781f68

update test comments

fb4bb0d

update check_unstable_variants's handling of `-C linker-features=[-…

4a95856

…+]lld` - separate enabling and disabling the feature in the error - add both polarities to the dedicated test - update documentation and precondition

add LinkerFeatures::as_str for error messages on the CLI

ba9d402

update check_unstable_variants's handling of unstable `-C linker-fe…

edcc506

…atures` - to show the enabled and disabled unstable features in the error

simplify LinkSelfContained::are_unstable_variants_set

601a7a4

remove default directive

fba89e0

update documentation

d988376

move the unstable `-Clinker-features` documentation to the stable book, as there's only a single feature, and it is now stable

update bootstrap mcp510 handling

5d920a3

now that it's been stabilized, beta and stage1 need to use different flags (-C vs -Z)

lqd force-pushed the stabilize-lld-test branch from 49cabaa to 5d920a3 Compare April 25, 2025 15:53

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Apr 25, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[do not merge] Preparation for LLD stabilization #138645

[do not merge] Preparation for LLD stabilization #138645

Kobzol commented Mar 18, 2025 •

edited

Loading

This comment has been minimized.

Kobzol commented Mar 18, 2025

bors commented Mar 18, 2025

bors commented Mar 19, 2025

This comment has been minimized.

bors commented Mar 25, 2025

This comment has been minimized.

bors commented Apr 4, 2025

lqd commented Apr 4, 2025

bors commented Apr 4, 2025

bors commented Apr 4, 2025

lqd commented Apr 25, 2025

bors commented Apr 25, 2025

rust-log-analyzer commented Apr 25, 2025

bors commented Apr 25, 2025

[do not merge] Preparation for LLD stabilization #138645

Are you sure you want to change the base?

[do not merge] Preparation for LLD stabilization #138645

Conversation

Kobzol commented Mar 18, 2025 • edited Loading

This comment has been minimized.

Kobzol commented Mar 18, 2025

bors commented Mar 18, 2025

bors commented Mar 19, 2025

This comment has been minimized.

bors commented Mar 25, 2025

This comment has been minimized.

bors commented Apr 4, 2025

lqd commented Apr 4, 2025

bors commented Apr 4, 2025

bors commented Apr 4, 2025

lqd commented Apr 25, 2025

bors commented Apr 25, 2025

rust-log-analyzer commented Apr 25, 2025

bors commented Apr 25, 2025

Kobzol commented Mar 18, 2025 •

edited

Loading