Rename internal module from statik to no_threads
#139121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
S-waiting-on-review
|
How about renaming it to "global"? "static" made me think of linker based TLS (in contrast to runtime created TLS) first before realizing it's just global for single threaded. Or maybe even no_threads. |
|
I think rust/library/std/src/sys/thread_local/statik.rs Lines 1 to 2 in 9e14530 |
|
On the inside it makes sense, but when just looking at the filename, no_threads is a lot clearer. Static is such an overloaded and confusing word that it's best avoided. |
This module is named in reference to the keyword, but the term is somewhat overloaded. Rename it to more clearly describe it and avoid the misspelling.
thaliaarchi
changed the title
statik to staticsstatik to no_threads
thaliaarchi
force-pushed
the
rename-thread_local-statik
branch
from
a5444b3 to
9b889e9
Compare
|
I've updated it for that change. |
|
awesome! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#136877 (Fix missing const for inherent pointer `replace` methods) - rust-lang#138797 (Fix `ProvenVia` for global where clauses) - rust-lang#139121 (Rename internal module from `statik` to `no_threads`) - rust-lang#139319 (StableMIR: Prepare for refactoring) - rust-lang#139404 (Small smir cleanup) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2025
Rollup merge of rust-lang#139121 - thaliaarchi:rename-thread_local-statik, r=Noratrieb Rename internal module from `statik` to `no_threads` This module is named in reference to the keyword, but the term is somewhat overloaded. Rename it to more clearly describe it and avoid the misspelling.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 10, 2025
…atik, r=Noratrieb Rename internal module from `statik` to `no_threads` This module is named in reference to the keyword, but the term is somewhat overloaded. Rename it to more clearly describe it and avoid the misspelling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is named in reference to the keyword, but the term is somewhat overloaded. Rename it to more clearly describe it and avoid the misspelling.