Skip to content

doc changes: debug assertions -> overflow checks #139447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

izarma
Copy link

@izarma izarma commented Apr 6, 2025

This PR is for the following issue:
#108131

has some changes in docs

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 6, 2025
@lolbinarycat lolbinarycat changed the title doc changes doc changes: debug assertions -> overflow checks Apr 8, 2025
@scottmcm
Copy link
Member

Normally I think I'd ask libs-api, but given that "debug assertions" have never been actually enableable in the standard library from a stable compiler and that these are mostly using rustc_inherit_overflow_checks in the implementation, https://doc.rust-lang.org/rustc/codegen-options/index.html#overflow-checks does seem like obviously better phrasing.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 10, 2025

📌 Commit f21d180 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Rollup of 12 pull requests

Successful merges:

 - rust-lang#137447 (add `core::intrinsics::simd::{simd_extract_dyn, simd_insert_dyn}`)
 - rust-lang#138182 (rustc_target: update x86_win64 to match the documented calling convention for f128)
 - rust-lang#138682 (Allow drivers to supply a list of extra symbols to intern)
 - rust-lang#138904 (Test linking and running `no_std` binaries)
 - rust-lang#138998 (Don't suggest the use of  `impl Trait` in closure parameter)
 - rust-lang#139447 (doc changes: debug assertions -> overflow checks)
 - rust-lang#139469 (Introduce a `//@ needs-crate-type` compiletest directive)
 - rust-lang#139564 (Deeply normalize obligations in `BestObligation` folder)
 - rust-lang#139574 (bootstrap: improve `channel` handling)
 - rust-lang#139600 (Update `compiler-builtins` to 0.1.153)
 - rust-lang#139641 (Allow parenthesis around inferred array lengths)
 - rust-lang#139654 (Improve `AssocItem::descr`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a7d7a6d into rust-lang:master Apr 11, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Rollup merge of rust-lang#139447 - izarma:issue-108131-fix, r=scottmcm

doc changes: debug assertions -> overflow checks

This PR is for the following issue:
rust-lang#108131

has some changes in docs
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
doc changes: debug assertions -> overflow checks

This PR is for the following issue:
rust-lang#108131

has some changes in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants