Skip to content

[beta] Delay hash_extract_if stabilization from 1.87 to 1.88 #139765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Apr 13, 2025

This PR is a revert of:

for use in the event that we are unable to get #139764 into 1.87 (current beta).

@rustbot
Copy link
Collaborator

rustbot commented Apr 13, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 13, 2025
@dtolnay
Copy link
Member Author

dtolnay commented Apr 13, 2025

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025
@ChrisDenton
Copy link
Member

r=me if/when necessary

@dtolnay
Copy link
Member Author

dtolnay commented Apr 28, 2025

Merging because there still hasn't been a hashbrown release containing rust-lang/hashbrown#616, and it is now getting too late in the cycle to backport a hashbrown update that would unblock #139764.

@bors r=ChrisDenton

@bors
Copy link
Collaborator

bors commented Apr 28, 2025

📌 Commit d8fad75 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Apr 28, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
…enton

Rollup of 10 pull requests

Successful merges:

 - rust-lang#139308 (add autodiff inline)
 - rust-lang#139656 (Stabilize `slice_as_chunks` library feature)
 - rust-lang#140022 (allow deref patterns to move out of boxes)
 - rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied)
 - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases)
 - rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`)
 - rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs)
 - rust-lang#140394 (Make bootstrap git tests more self-contained)
 - rust-lang#140396 (Workaround for windows-gnu rust-lld test failure)
 - rust-lang#140402 (only return nested goals for `Certainty::Yes`)

Failed merges:

 - rust-lang#139765 ([beta] Delay `hash_extract_if` stabilization from 1.87 to 1.88)

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35
Copy link
Contributor

@bors rollup=never

A bit weird that bors seems to allow rolling up PRs that target different branches

@bors
Copy link
Collaborator

bors commented Apr 28, 2025

⌛ Testing commit d8fad75 with merge 9d6fe3d1b2e24fad0574ef47915df47c72ba2ee3...

@bors
Copy link
Collaborator

bors commented Apr 29, 2025

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 9d6fe3d to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 29, 2025
@bors bors merged commit 9d6fe3d into rust-lang:beta Apr 29, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants