norm nested aliases before evaluating the parent goal #140236
Merged
+155
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rust-cloud-vms
bot
force-pushed
the
normalizes-to-goals
branch
from
af161c3 to
ba259b9
Compare
lcnr
commented
Apr 24, 2025
| @@ -137,6 +136,7 @@ impl<'tcx> Predicate<'tcx> { | |||
| | PredicateKind::Coerce(_) | |||
| | PredicateKind::Clause(ClauseKind::ConstEvaluatable(_)) | |||
| | PredicateKind::ConstEquate(_, _) | |||
| | PredicateKind::NormalizesTo(..) | |||
| | PredicateKind::Ambiguous => true, | |||
There was a problem hiding this comment.
we're actually free to normalize NormalizesTo goals. The alias we're normalizing is already an AliasTerm so we only ever normalize the arguments, not the alias itself.
We actually already did this before this PR because we directly folded a Goal<I, NormalizesTo<I>> for NormalizesTo goals.
We could in theory also normalize the arguments of aliases in AliasRelate. However, setting allow_normalization to true for this would cause us to also attempt to normalize the aliases we're actually relating. Given that we use AliasRelate to do so, that would result in a trivial cycle.
rust-cloud-vms
bot
force-pushed
the
normalizes-to-goals
branch
from
ba259b9 to
02e3491
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 ~~[top 100 most downloaded crates on crates.io compile](rust-lang#133502 (comment) [top 1000 most downloaded crates on crates.io compile](rust-lang#133502 (comment)) [first perf run](rust-lang#133502 (comment)) 👻 ### in-flight changes - rust-lang#124852, unsure whether I actually want to land this PR for now - rust-lang#140236 - rust-lang#139587 - https://github.com/lcnr/rust/tree/opaque-type-method-call - normalize when checking whether param env candidates are global - double the available recursion depth in the new solver ☠️ r? `@ghost`
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
normalizes-to-goals
branch
from
02e3491 to
e5e3a95
Compare
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#137653 (Deprecate the unstable `concat_idents!`) - rust-lang#138957 (Update the index of Option to make the summary more comprehensive) - rust-lang#140006 (ensure compiler existance of tools on the dist step) - rust-lang#140143 (Move `sys::pal::os::Env` into `sys::env`) - rust-lang#140202 (Make #![feature(let_chains)] bootstrap conditional in compiler/) - rust-lang#140236 (norm nested aliases before evaluating the parent goal) - rust-lang#140257 (Some drive-by housecleaning in `rustc_borrowck`) - rust-lang#140278 (Don't use item name to look up associated item from trait item) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2025
Rollup merge of rust-lang#140236 - lcnr:normalizes-to-goals, r=compiler-errors norm nested aliases before evaluating the parent goal see the explanation of the underlying issue in tests/ui/traits/next-solver/normalize/eager-norm-pre-normalizes-to.rs. This is also the cause of rust-lang/trait-system-refactor-initiative#184, fixing the overflow errors with the new solver. I did not add any tests based on it directly as relying on that behavior to cause recursion limit shenanigans feels fragile. Thanks `@Nadrieril` for minimizing the issue [on zulip](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/typenum.20.602.20.2F.201.60.20overflow.20error/with/513993621). r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the explanation of the underlying issue in tests/ui/traits/next-solver/normalize/eager-norm-pre-normalizes-to.rs.
This is also the cause of rust-lang/trait-system-refactor-initiative#184, fixing the overflow errors with the new solver. I did not add any tests based on it directly as relying on that behavior to cause recursion limit shenanigans feels fragile. Thanks @Nadrieril for minimizing the issue on zulip.
r? @compiler-errors