Subtree update cg_gcc 2025/04/25 #140295
Merged
Subtree update cg_gcc 2025/04/25 #140295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update_cg_gcc_2025-04-18
…affleLapkin simd intrinsics with mask: accept unsigned integer masks, and fix some of the errors It's not clear at all why the mask would have to be signed, it is anyway interpreted bitwise. The backend should just make sure that works no matter the surface-level type; our LLVM backend already does this correctly. The note of "the mask may be widened, which only has the correct behavior for signed integers" explains... nothing? Why can't the code do the widening correctly? If necessary, just cast to the signed type first... Also while we are at it, fix the errors. For simd_masked_load/store, the errors talked about the "third argument" but they meant the first argument (the mask is the first argument there). They also used the wrong type for `expected_element`. I have extremely low confidence in the GCC part of this PR. See [discussion on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/257879-project-portable-simd/topic/On.20the.20sign.20of.20masks)
…4_25_2 Sync from rust 2025/04/25
…update_cg_gcc_2025-04-25
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_gcc |
GuillaumeGomez
approved these changes
Apr 25, 2025
|
@bors r+ rollup=never p=1 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance no pull requests found for branch "master" |
|
Finished benchmarking commit (555e1d0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 775.721s -> 776.189s (0.06%) |
|
@rust-lang/infra Is this normal to have the CI failing but still the PR getting merged? |
|
It's just the post-merge report that failed, the auto tests were fine. I'll take a look. |
|
Hmm, for some reason GH was unable to find a PR corresponding to the SHA that was merged. I'll keep a watch on this in case it repeats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? GuillaumeGomez