Skip to content

Update the edition guide for let chains #140852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

est31
Copy link
Member

@est31 est31 commented May 9, 2025

Pull rust-lang/edition-guide#337 into the rustc tree.

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@est31 est31 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 9, 2025
@est31
Copy link
Member Author

est31 commented May 9, 2025

Nominating this for beta 1.88.0 backport as it is the release that has the stabilization of let chains. Not sure when exactly it branches from master. This is not about 1.87.0 which will be released next week.

@ehuss
Copy link
Contributor

ehuss commented May 9, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit 577e82f has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
@ehuss ehuss added beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 9, 2025
…ehuss

Update the edition guide for let chains

Pull rust-lang/edition-guide#337 into the rustc tree.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#139863 (rustdoc: Replace unstable flag `--doctest-compilation-args` with a simpler one: `--doctest-build-arg`)
 - rust-lang#140815 (also export metrics from librustdoc)
 - rust-lang#140819 (Add regression test for 125877)
 - rust-lang#140843 (Fix `broken-pipe-no-ice` run-make test for rpath-less builds)
 - rust-lang#140848 (Improved error message for top-level or-patterns)
 - rust-lang#140852 (Update the edition guide for let chains)
 - rust-lang#140864 (Last minute relnotes fix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab1f382 into rust-lang:master May 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
Rollup merge of rust-lang#140852 - est31:edition_guide_let_chains, r=ehuss

Update the edition guide for let chains

Pull rust-lang/edition-guide#337 into the rustc tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants