-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Turn stdarch
into a Josh subtree
#141899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Turn stdarch
into a Josh subtree
#141899
Conversation
This commit adds support for `riscv_hwprobe` on the Linux kernel 6.15. It adds feature detection of 8 extensions (4 of them are new in this). Existing RISC-V Extensions: 1. "Zicntr" 2. "Zihpm" 3. "Zalrsc" 4. "Zaamo" New RISC-V Extensions: 5. "Zicbom" 6. "Zfbfmin" 7. "Zvfbfmin" 8. "Zvfbfwma"
FCP completed in tracking issue rust-lang#111137
Thanks a lot! However, I feel like this should be approved by t-libs... maybe r? @Amanieu ? Also it my be a good idea to wait for compiler-builtins having their first successful syncs in both directions to ensure there's no hidden pitfalls in the setup. How hard would it be to add a smoke test that at least checks that the crates build by themselves (i.e., outside of libcore)? That should be feasible wrt CI time and should catch some of the obvious issues -- the |
Definitely agreed.
Yeah, I think we should do at least some smoke test. I guess that we could do it in bootstrap, I'll take a look. |
☔ The latest upstream changes (presumably #141229) made this pull request unmergeable. Please resolve the merge conflicts. |
This is going to conflict with #141964 which updates the submodule. |
Is it required to build them using the in-tree rustc? Or is it enough to use stage0/beta compiler? Is it enough to just run |
Well, the goal is to avoid multi-PR transitions for things like renaming an intrinsic that stdarch uses. So ideally the in-tree rustc is the only one that we require to be able to build stdarch. |
@bors2 try |
Turn `stdarch` into a Josh subtree In a similar vein as #141229, this PR makes the `stdarch` repository a Josh subtree (it was previously a submodule). The initial commit of `stdarch` upon this is based is `b6e2249e388f520627544812649b77b0944e1a2e`, which is the previous commit SHA of the `stdarch` submodule. The sync was performed according to https://hackmd.io/7pOuxnkdQDaL1Y1FQr65xg. This was decided in rust-lang/stdarch#1655. Test pull PR on my fork: Kobzol/stdarch#1 Test push PR on my fork: Kobzol#59 I plan to use the same Rust (miri-inspired) tooling that we use for `rustc-dev-guide` to enable pulls/pushes on stdarch. Note that this repository currently doesn't have any stdarch-specific tests, so before that, the subtree should only be modified through this repository only when dealing with changes that contain "cyclical dependencies" between stdarch and rustc. The long term vision is to integrate stdarch into rust-lang/rust completely. CC `@Amanieu` try-job: aarch64-apple try-job: aarch64-gnu try-job: `x86_64-msvc-*` try-job: x86_64-gnu try-job: x86_64-gnu-aux
In a similar vein as #141229, this PR makes the
stdarch
repository a Josh subtree (it was previously a submodule). The initial commit ofstdarch
upon this is based isb6e2249e388f520627544812649b77b0944e1a2e
, which is the previous commit SHA of thestdarch
submodule. The sync was performed according to https://hackmd.io/7pOuxnkdQDaL1Y1FQr65xg.This was decided in rust-lang/stdarch#1655.
Test pull PR on my fork: Kobzol/stdarch#1
Test push PR on my fork: Kobzol#59
I plan to use the same Rust (miri-inspired) tooling that we use for
rustc-dev-guide
to enable pulls/pushes on stdarch.Note that this repository currently doesn't have any stdarch-specific tests, so before that, the subtree should only be modified through this repository only when dealing with changes that contain "cyclical dependencies" between stdarch and rustc. The long term vision is to integrate stdarch into rust-lang/rust completely.
CC @Amanieu
try-job: aarch64-apple
try-job: aarch64-gnu
try-job:
x86_64-msvc-*
try-job: x86_64-gnu
try-job: x86_64-gnu-aux