Skip to content

Attempted to fix #141972 Parameter ABI inconsistency error in Rust for RISC-V #141979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Attempted to fix #141972 Parameter ABI inconsistency error in Rust for RISC-V #141979

wants to merge 4 commits into from
+1,006 −12

Conversation

YingkaiLi-VM
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

r? @workingjubilee

sorry for not reviewing your PR yet, @beetrees, but can you check if this would overlap with #139340

@rustbot rustbot assigned workingjubilee and unassigned fee1-dead Jun 3, 2025
@beetrees
Copy link
Contributor

beetrees commented Jun 3, 2025

This is unrelated: #139340 is about structs with floating point fields passed via the "C" ABI, whereas #141972 is about integers being passed with the "Rust" ABI.

@workingjubilee
Copy link
Member

@YingkaiLi-VM please rebase on the current master branch

@workingjubilee workingjubilee removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2025
@bors
Copy link
Collaborator

bors commented Jun 9, 2025

☔ The latest upstream changes (presumably #142220) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 9, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jun 11, 2025
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025
@YingkaiLi-VM
Copy link
Author

@bors @workingjubilee Okay，Merge conflicts resolved. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YingkaiLi-VM @rustbot @rust-log-analyzer @workingjubilee @beetrees @bors @fee1-dead