Add musl submodule to .gitmodules #142029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler-builtins subtree has musl as a submodule, but it is not present in the git root .gitmodules. This breaks some workflows with `build.submodules = false` That is, a naive `git submodule update --init` will error out with: ``` fatal: No url found for submodule path 'library/compiler-builtins/crates/musl-math-sys/musl' in .gitmodules ```
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
|
I hoped that we would just wait for rust-lang/compiler-builtins#944 to get rid of the submodule. But if this is blocking people, then I guess we could add it in the meantime. |
|
Looks like rust-lang/compiler-builtins#944 is going to be synced over soon, so there's no need for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler-builtins subtree has musl as a submodule, but it is not present in the git root .gitmodules. This breaks some workflows with
build.submodules = falseThat is, a naivegit submodule update --initwill error out with: