Skip to content

Verbose suggestion to make param const #142043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

Verbose suggestion to make param const #142043

merged 1 commit into from
Jun 7, 2025
+22 −10

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jun 4, 2025 •
edited by rustbot
Loading 

error[E0747]: type provided when a constant was expected
  --> $DIR/invalid-const-arguments.rs:10:19
   |
LL | impl<N> Foo for B<N> {}
   |                   ^
   |
help: consider changing this type parameter to a const parameter
   |
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
   |

Part of #141973.

@estebank
Verbose suggestion to make param const
35cb28b 
```
error[E0747]: type provided when a constant was expected
  --> $DIR/invalid-const-arguments.rs:10:19
   |
LL | impl<N> Foo for B<N> {}
   |                   ^
   |
help: consider changing this type parameter to a const parameter
   |
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
   |
```
@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

HIR ty lowering was modified

cc @fmease

@wesleywiser
Copy link
Member

r=me when CI is green

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 6, 2025

📌 Commit 35cb28b has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 6, 2025
Merged
bors added a commit that referenced this pull request Jun 7, 2025
@bors
Auto merge of #142133 - GuillaumeGomez:rollup-fvzdren, r=GuillaumeGomez
775e0c8 
Rollup of 11 pull requests

Successful merges:

 - #140418 (Reexport types from `c_size_t` in `std`)
 - #141471 (unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract)
 - #141603 (Reduce `ast::ptr::P` to a typedef of `Box`)
 - #142043 (Verbose suggestion to make param `const`)
 - #142086 (duduplicate more AST visitor methods)
 - #142103 (Update `InterpCx::project_field` to take `FieldIdx`)
 - #142105 (remove extraneous text)
 - #142112 (fix typo)
 - #142113 (Reduce confusion of some drop order tests)
 - #142114 (Compute number of digits instead of relying on constant value for u128 display code)
 - #142118 (rustc_lexer: typo fix + small cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4ce2db5 into rust-lang:master Jun 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
rust-timer added a commit that referenced this pull request Jun 7, 2025
@rust-timer
Unrolled build for #142043
771b39b 
Rollup merge of #142043 - estebank:const-suggestion, r=wesleywiser

Verbose suggestion to make param `const`

```
error[E0747]: type provided when a constant was expected
  --> $DIR/invalid-const-arguments.rs:10:19
   |
LL | impl<N> Foo for B<N> {}
   |                   ^
   |
help: consider changing this type parameter to a const parameter
   |
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
   |
```

Part of #141973.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 7, 2025
@bors
Auto merge of #142133 - GuillaumeGomez:rollup-fvzdren, r=GuillaumeGomez
951ed8d 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#140418 (Reexport types from `c_size_t` in `std`)
 - rust-lang/rust#141471 (unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract)
 - rust-lang/rust#141603 (Reduce `ast::ptr::P` to a typedef of `Box`)
 - rust-lang/rust#142043 (Verbose suggestion to make param `const`)
 - rust-lang/rust#142086 (duduplicate more AST visitor methods)
 - rust-lang/rust#142103 (Update `InterpCx::project_field` to take `FieldIdx`)
 - rust-lang/rust#142105 (remove extraneous text)
 - rust-lang/rust#142112 (fix typo)
 - rust-lang/rust#142113 (Reduce confusion of some drop order tests)
 - rust-lang/rust#142114 (Compute number of digits instead of relying on constant value for u128 display code)
 - rust-lang/rust#142118 (rustc_lexer: typo fix + small cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
4 participants
@estebank @rustbot @wesleywiser @bors