Add examples for edge cases of str.split/str.splitn #14335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, show examples for splitting the empty string and using `splitn` with a count of 0. Fix rust-lang#14222.
|
@pnkfelix, you may want to take a look at this to ensure that you're satisfied with the number of documented variations. |
|
Yeah these examples are sufficient, I think someone who cares should be able to derive the right interpretation from the corner-cases shown here. |
bors
added a commit
that referenced
this pull request
May 22, 2014
In particular, show examples for splitting the empty string and using `splitn` with a count of 0. Fix #14222.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, show examples for splitting the empty string and using
splitnwith a count of 0.
Fix #14222.