Skip to content

Various refactors to the LTO handling code#143388

Merged
bors merged 9 commits intorust-lang:masterfrom
bjorn3:lto_refactors
Jul 17, 2025
Merged

Various refactors to the LTO handling code#143388
bors merged 9 commits intorust-lang:masterfrom
bjorn3:lto_refactors

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jul 3, 2025

In particular reducing the sharing of code paths between fat and thin-LTO and making the fat LTO implementation more self-contained. This also moves some autodiff handling out of cg_ssa into cg_llvm given that Enzyme only works with LLVM anyway and an implementation for another backend may do things entirely differently. This will also make it a bit easier to split LTO handling out of the coordinator thread main loop into a separate loop, which should reduce the complexity of the coordinator thread.

bjorn3 added 9 commits July 3, 2025 14:28
@bjorn3
Remove LtoModuleCodegen
653bb64 
Most uses of it either contain a fat or thin lto module. Only
WorkItem::LTO could contain both, but splitting that enum variant
doesn't complicate things much.
@bjorn3
Move dcx creation into WriteBackendMethods::codegen
7fd78df
@bjorn3
Fat LTO always produces a single object file, so -Zcombine-cgu has no…
ee280a5 
… effect
@bjorn3
Split generate_lto_work between fat and thin-LTO cases
797084d
@bjorn3
Pass in autodiff items when starting the coordinator thread
332f1b1 
As opposed to sending a message to the coordinator thread.
@bjorn3
Move run_fat_lto call into execute_fat_lto_work_item
779cb00 
This will allow merging all fat LTO steps together. In addition it
reduces the amount of work done on the coordinator thread without
jobserver token.
@bjorn3
Remove unnecessary check for fat LTO
9a3aa8f
@bjorn3
Remove unused config param from WriteBackendMethods::autodiff
8d63c7a
@bjorn3
Merge run_fat_lto, optimize_fat and autodiff into run_and_optimize_fa…
21026ca 
…t_lto
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

bjorn3
bjorn3 commented Jul 4, 2025
View reviewed changes
compiler/rustc_codegen_ssa/src/back/write.rs
));
if cgcx.parallel {
helper.request_token();
}
Copy link
Member Author

@bjorn3 bjorn3 Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is necessary for fat LTO given that only a single thread will be doing LTO work and we have the implicit token anyway. It is pre-existing though and the token should be immediately yielded back to the jobserver if we indeed don't actually use it.

Copy link
Member

@ZuseZ4 ZuseZ4 Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My latest cleanup pr removes the clone, but you can land this pr first, as you say it didn't really hurt.

Copy link
Member Author

@bjorn3 bjorn3 Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually talking about the helper.request_token() call.

@compiler-errors
Copy link
Contributor

compiler-errors commented Jul 16, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

📌 Commit 21026ca has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 16, 2025
@fmease
Rollup merge of rust-lang#143388 - bjorn3:lto_refactors, r=compiler-e…
9e0ada2 
…rrors

Various refactors to the LTO handling code

In particular reducing the sharing of code paths between fat and thin-LTO and making the fat LTO implementation more self-contained. This also moves some autodiff handling out of cg_ssa into cg_llvm given that Enzyme only works with LLVM anyway and an implementation for another backend may do things entirely differently. This will also make it a bit easier to split LTO handling out of the coordinator thread main loop into a separate loop, which should reduce the complexity of the coordinator thread.
@fmease fmease mentioned this pull request Jul 16, 2025
Closed
bors added a commit that referenced this pull request Jul 17, 2025
@bors
Auto merge of #144041 - fmease:rollup-spzdlyz, r=fmease
c0f46ce 
Rollup of 15 pull requests

Successful merges:

 - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - #143388 (Various refactors to the LTO handling code)
 - #143409 (Enable xgot feature for mips64 musl targets)
 - #143592 (UWP: link ntdll functions using raw-dylib)
 - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - #143678 (Added error for invalid char cast)
 - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - #143829 (Trim `BorrowedCursor` API)
 - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests)
 - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - #143856 (Linting public reexport of private dependencies)
 - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - #143922 (Improve path segment joining)
 - #143964 (Fix handling of SCRIPT_ARG in docker images)
 - #144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jul 17, 2025
Merged
bors added a commit that referenced this pull request Jul 17, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
f8f6997 
Rollup of 15 pull requests

Successful merges:

 - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - #143388 (Various refactors to the LTO handling code)
 - #143409 (Enable xgot feature for mips64 musl targets)
 - #143592 (UWP: link ntdll functions using raw-dylib)
 - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - #143678 (Added error for invalid char cast)
 - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - #143829 (Trim `BorrowedCursor` API)
 - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - #143856 (Linting public reexport of private dependencies)
 - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - #143922 (Improve path segment joining)
 - #143964 (Fix handling of SCRIPT_ARG in docker images)
 - #144002 (Update poison.rs)
 - #144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit be5f8f2 into rust-lang:master Jul 17, 2025
21 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 17, 2025
rust-timer added a commit that referenced this pull request Jul 17, 2025
@rust-timer
Unrolled build for #143388
a174bde 
Rollup merge of #143388 - bjorn3:lto_refactors, r=compiler-errors

Various refactors to the LTO handling code

In particular reducing the sharing of code paths between fat and thin-LTO and making the fat LTO implementation more self-contained. This also moves some autodiff handling out of cg_ssa into cg_llvm given that Enzyme only works with LLVM anyway and an implementation for another backend may do things entirely differently. This will also make it a bit easier to split LTO handling out of the coordinator thread main loop into a separate loop, which should reduce the complexity of the coordinator thread.
@bjorn3 bjorn3 deleted the lto_refactors branch July 17, 2025 09:07
@bjorn3 bjorn3 mentioned this pull request Jul 17, 2025
Merged
rust-bors bot added a commit that referenced this pull request Jul 17, 2025
@rust-bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=<try>
f1a7db9 
Various refactors to the LTO handling code (part 2)

Continuing from #143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@fmease @Muscraft
Rollup merge of rust-lang#143388 - bjorn3:lto_refactors, r=compiler-e…
a3371fa 
…rrors

Various refactors to the LTO handling code

In particular reducing the sharing of code paths between fat and thin-LTO and making the fat LTO implementation more self-contained. This also moves some autodiff handling out of cg_ssa into cg_llvm given that Enzyme only works with LLVM anyway and an implementation for another backend may do things entirely differently. This will also make it a bit easier to split LTO handling out of the coordinator thread main loop into a separate loop, which should reduce the complexity of the coordinator thread.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144044 - fmease:rollup-kg413pt, r=fmease
e3e96c8 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang#143388 (Various refactors to the LTO handling code)
 - rust-lang#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang#143678 (Added error for invalid char cast)
 - rust-lang#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang#143829 (Trim `BorrowedCursor` API)
 - rust-lang#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang#143856 (Linting public reexport of private dependencies)
 - rust-lang#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang#143922 (Improve path segment joining)
 - rust-lang#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang#144002 (Update poison.rs)
 - rust-lang#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
5d22242 
Various refactors to the LTO handling code (part 2)

Continuing from #143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
a771cc3 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 28, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
5088611 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Jul 28, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
3f9d20c 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jul 28, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
9959226 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull request Aug 3, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
a4ac1e4 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Aug 4, 2025
@fmease
Rollup merge of rust-lang#143388 - bjorn3:lto_refactors, r=compiler-e…
7ff6135 
…rrors

Various refactors to the LTO handling code

In particular reducing the sharing of code paths between fat and thin-LTO and making the fat LTO implementation more self-contained. This also moves some autodiff handling out of cg_ssa into cg_llvm given that Enzyme only works with LLVM anyway and an implementation for another backend may do things entirely differently. This will also make it a bit easier to split LTO handling out of the coordinator thread main loop into a separate loop, which should reduce the complexity of the coordinator thread.
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Aug 9, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
f1648f3 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
fd6d086 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang/rust#143388 (Various refactors to the LTO handling code)
 - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang/rust#143678 (Added error for invalid char cast)
 - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang/rust#143829 (Trim `BorrowedCursor` API)
 - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang/rust#143856 (Linting public reexport of private dependencies)
 - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang/rust#143922 (Improve path segment joining)
 - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang/rust#144002 (Update poison.rs)
 - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
e956d3b 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
f585733 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang/rust#143388 (Various refactors to the LTO handling code)
 - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang/rust#143678 (Added error for invalid char cast)
 - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang/rust#143829 (Trim `BorrowedCursor` API)
 - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang/rust#143856 (Linting public reexport of private dependencies)
 - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang/rust#143922 (Improve path segment joining)
 - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang/rust#144002 (Update poison.rs)
 - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
b6dd1a2 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
@bjorn3 bjorn3 mentioned this pull request Sep 5, 2025
Closed
12 tasks
@ZuseZ4 ZuseZ4 mentioned this pull request Oct 28, 2025
Closed
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge of rust-lang#144044 - fmease:rollup-kg413pt, r=fmease
191f4cd 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang#143388 (Various refactors to the LTO handling code)
 - rust-lang#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang#143678 (Added error for invalid char cast)
 - rust-lang#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang#143829 (Trim `BorrowedCursor` API)
 - rust-lang#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang#143856 (Linting public reexport of private dependencies)
 - rust-lang#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang#143922 (Improve path segment joining)
 - rust-lang#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang#144002 (Update poison.rs)
 - rust-lang#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge of rust-lang#144062 - bjorn3:lto_refactors2, r=davidtwco
c7e73ee 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge of rust-lang#144044 - fmease:rollup-kg413pt, r=fmease
ea3338f 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang#143388 (Various refactors to the LTO handling code)
 - rust-lang#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang#143678 (Added error for invalid char cast)
 - rust-lang#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang#143829 (Trim `BorrowedCursor` API)
 - rust-lang#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang#143856 (Linting public reexport of private dependencies)
 - rust-lang#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang#143922 (Improve path segment joining)
 - rust-lang#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang#144002 (Update poison.rs)
 - rust-lang#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge of rust-lang#144062 - bjorn3:lto_refactors2, r=davidtwco
c4e8320 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
455c7cb 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang/rust#143388 (Various refactors to the LTO handling code)
 - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang/rust#143678 (Added error for invalid char cast)
 - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang/rust#143829 (Trim `BorrowedCursor` API)
 - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang/rust#143856 (Linting public reexport of private dependencies)
 - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang/rust#143922 (Improve path segment joining)
 - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang/rust#144002 (Update poison.rs)
 - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
dfcf534 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #144044 - fmease:rollup-kg413pt, r=fmease
a898ba7 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test)
 - rust-lang/rust#143388 (Various refactors to the LTO handling code)
 - rust-lang/rust#143409 (Enable xgot feature for mips64 musl targets)
 - rust-lang/rust#143592 (UWP: link ntdll functions using raw-dylib)
 - rust-lang/rust#143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call)
 - rust-lang/rust#143678 (Added error for invalid char cast)
 - rust-lang/rust#143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - rust-lang/rust#143829 (Trim `BorrowedCursor` API)
 - rust-lang/rust#143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test)
 - rust-lang/rust#143856 (Linting public reexport of private dependencies)
 - rust-lang/rust#143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates)
 - rust-lang/rust#143922 (Improve path segment joining)
 - rust-lang/rust#143964 (Fix handling of SCRIPT_ARG in docker images)
 - rust-lang/rust#144002 (Update poison.rs)
 - rust-lang/rust#144016 (trait_sel: `MetaSized` always holds temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
ef6efee 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #144062 - bjorn3:lto_refactors2, r=davidtwco
7f02c3e 
Various refactors to the LTO handling code (part 2)

Continuing from rust-lang/rust#143388 this removes a bit of dead code and moves the LTO symbol export calculation from individual backends to cg_ssa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZuseZ4 ZuseZ4 ZuseZ4 left review comments

Assignees

@compiler-errors compiler-errors

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rustbot @compiler-errors @bors @ZuseZ4