make check was failing with PLEASE_BENCH=1 #14368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is a hash on a struct that used to have a ~str in it. The ~str was removed from the struct, so the hard coded hash value in the bench was now wrong. Wasn't caught in testing because the benches are no longer run. |
|
This looks like it's a hash on a struct with a u8 and a u64, where is the |
|
It was removed in commit 806ae06683b9. Perhaps I should put it back in as a StrBuf rather than adjusting the hash value. |
|
IMO we should just remove the assert entirely and feed the output to |
bors
added a commit
that referenced
this pull request
May 23, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
MIR episode 3 This PR adds lowering for try operator and overloaded dereference, and adds evaluating support for function pointers and trait objects. It also adds a flag to `analysis-stats` to show percentage of functions that it fails to emit mir for them, which is currently `20%` (which is somehow lying, as most of the supported `80%` are tests). The most offenders are closure (1975 items) and overloaded index (415 items). I will try to add overloaded index before monday to have it in this PR, and tackle the closure in the next episode.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
…e decompose directly (rust-lang#14370) Closes rust-lang#11617 Closes rust-lang#14368 Clippy gives wrong suggestions when the filter and then cannot be put into closure directly. Since trying to transform these can be too complicated, Clippy will simply warn but don't try to fix. changelog: [`filter_map_bool_then`]: fix wrong suggestions when the closure cannot be decompose directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.