core: Finish stabilizing the mem module.
#14392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All of the *_val functions have gone from #[unstable] to #[stable] * The overwrite and zeroed functions have gone from #[unstable] to #[stable] * The uninit function is now deprecated, replaced by its stable counterpart, uninitialized [breaking-change]
| @@ -164,7 +164,7 @@ impl rtio::RtioFileStream for FileDesc { | |||
| } | |||
|
|
|||
| fn fstat(&mut self) -> IoResult<io::FileStat> { | |||
| let mut stat: libc::stat = unsafe { mem::uninit() }; | |||
| let mut stat: libc::stat = unsafe { mem::zeroed() }; | |||
There was a problem hiding this comment.
Any particular reason these changed to zeroed instead of uninitialized?
There was a problem hiding this comment.
When doing FFI things I prefer to use zeroed things, I think I just accidentally left these all as uninitialized.
bors
added a commit
that referenced
this pull request
May 24, 2014
* All of the *_val functions have gone from #[unstable] to #[stable] * The overwrite and zeroed functions have gone from #[unstable] to #[stable] * The uninit function is now deprecated, replaced by its stable counterpart, uninitialized [breaking-change]
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Mar 20, 2025
…ust-lang#14392) If types such as `Option<Option<String>>` are not used by value, then `Option<Option<&String>>` will be suggested, instead of `Option<&Option<String>>`. changelog: [`needless_pass_by_value`]: suggest using a reference on the innermost `Option` content fix rust-lang#14375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninitialized
[breaking-change]