Help optimize out bounds checks in median_of_medians #144327
Draft
+25
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM can't see that
assert!((v / 200) <= (v / 2))
is always true, so it couldn't remove bounds inmedian_of_ninthers
..unwrap()
outside ofmin_index()
was losing bounds information. I've even triedassume(index < slice.len()); return Some(index)
, but it didn't help. Only moving theunwrap()
to inside the function seems to keep the range information (and doesn't needassume
).Part of #144326