Num cleanup #14694
Merged
Num cleanup #14694
+445
−437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bjz |
| impl_integer_for_uint!(u16, test_integer_u16) | ||
| impl_integer_for_uint!(u32, test_integer_u32) | ||
| impl_integer_for_uint!(u64, test_integer_u64) | ||
| impl_integer_for_uint!(uint, test_integer_uint) |
There was a problem hiding this comment.
this last line isn't terminated.
There was a problem hiding this comment.
Thanks! It should be fixed now.
|
Looks fine to me. |
| @@ -975,7 +967,7 @@ impl Div<BigInt, BigInt> for BigInt { | |||
| #[inline] | |||
| fn div(&self, other: &BigInt) -> BigInt { | |||
| let (q, _) = self.div_rem(other); | |||
| return q; | |||
| q | |||
There was a problem hiding this comment.
These may also be expressed as self.div_rem(other).val0().
|
Could you squash the last commit into one of the first two? Other than that I think this is good to go! |
|
Done! |
bors
added a commit
that referenced
this pull request
Jun 10, 2014
bors
added a commit
that referenced
this pull request
Jun 10, 2014
Closes #14611 (std: Remove the as_utf16_p functions) Closes #14694 (Num cleanup) Closes #14760 (Add --color to test binary options) Closes #14763 (std: Move dynamic_lib from std::unstable to std) Closes #14766 (Add test for issue #13446) Closes #14769 (collections: Add missing Default impls) Closes #14773 (General nits) Closes #14776 (rustdoc: Correctly classify enums/typedefs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.