move GAT inference prevention hack #148865
Merged
+104
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
lcnr
force-pushed
the
gat-inference-hack
branch
from
a8764d3 to
28c0fd3
Compare
lcnr
force-pushed
the
gat-inference-hack
branch
from
28c0fd3 to
15b02a9
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 5 pull requests Successful merges: - #145610 (Stabilize `char_max_len`) - #148504 (Fix link in c_longlong documentation) - #148698 (Fix query cycle when encounter unevaluated const) - #148865 (move GAT inference prevention hack) - #149016 (Document the `let this = self;` idiom used in MIR building) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup merge of #148865 - lcnr:gat-inference-hack, r=BoxyUwU move GAT inference prevention hack The structure of `fn assemble_and_merge_candidates` is quite messy and the differences between `Host` and `NormalizesTo` goals is large enough that we should split them entirely. Intend to change this for rust-lang/trait-system-refactor-initiative#245 by mentoring someone: https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/554696331. Think it's still fine to merge this PR without that larger change. fixes rust-lang/trait-system-refactor-initiative#256 r? `@BoxyUwU`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 20, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#145610 (Stabilize `char_max_len`) - rust-lang/rust#148504 (Fix link in c_longlong documentation) - rust-lang/rust#148698 (Fix query cycle when encounter unevaluated const) - rust-lang/rust#148865 (move GAT inference prevention hack) - rust-lang/rust#149016 (Document the `let this = self;` idiom used in MIR building) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of
fn assemble_and_merge_candidatesis quite messy and the differences betweenHostandNormalizesTogoals is large enough that we should split them entirely. Intend to change this for rust-lang/trait-system-refactor-initiative#245 by mentoring someone: https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/554696331. Think it's still fine to merge this PR without that larger change.fixes rust-lang/trait-system-refactor-initiative#256
r? @BoxyUwU